Update minimum required CMake version #308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be merged @perlpunk because libraries depending on libyaml cannot compile? |
|
If you encounter this issue, use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake v4.0 just came out, and is not compatible with CMake versions less than 3.5. So, if you try to build libyaml with CMake v4.0, cmake throws an error because in the main branch, the CMakeLists.txt file has the line
cmake_minimum_required(VERSION 3.0). This pull requests changes the minimum required version of CMake from v3.0 to v3.20 so that libyaml builds with the latest versions of CMake.