fix patching of nested structs #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when nesting structs, the patches should also use nested patches instead of the original nested structs, otherwise a patch with a nested structure can not be deserialized from json (the original non-patched struct is used to deserialize the json and if fields are missing, it fails) this pr solves the problem by introducing #[patch_name = <name>] attribute that can be added to fields. The name should point to the patch structure that should be used instead of the original. This attribute then causes 2 things to happen: 1. The new name is used for the type of the field in generated code 2. It generates different methods in the Patch traits based on if the fields are renamed or not
yanganto
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when nesting structs, the patches should also use nested patches instead of the original nested structs, otherwise a patch with a nested structure can not be deserialized from json (the original non-patched struct is used to deserialize the json and if fields are missing, it fails)
this pr solves the problem by introducing #[patch_name = ] attribute that can be added to fields. The name should point to the patch structure that should be used instead of the original. This attribute then causes 2 things to happen:
This should fix #21