feat: Handle generic types #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yanganto It seems that the linter does not work on forks: Can you help me with this problem please |
|
Thanks for this PR 🙏. This PR is awesome and it already has test cases. Are you still working on this? You can try to rebase it. Otherwise, I will merge it, I believe this PR is good enough, and I will take care of it, and release it as soon as possible. |
|
Sorry for the delay. Your contribution is now in the new release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
Improvement of the patch derive to handle generic structs and custom generic patch struct.
Added some unit tests to check my changes.