Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix ESLint E2Es failing since v9 release #6444

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

ci: fix ESLint E2Es failing since v9 release #6444

wants to merge 3 commits into from

Conversation

wojtekmaj
Copy link
Contributor

@wojtekmaj wojtekmaj commented Aug 8, 2024 •
edited
Loading

What's the problem this PR addresses?

Since ESLint v9 release, our E2Es were failing due to a breaking change in how ESLint config is defined (flat config).

How did you fix it?

Reimplemented ESLint config

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@wojtekmaj wojtekmaj requested a review from arcanis as a code owner August 8, 2024 09:47
@wojtekmaj wojtekmaj changed the title ci: fix ESLint E2Es failing since v9 release fix(ci): fix ESLint E2Es failing since v9 release Aug 8, 2024
@merceyz merceyz changed the title fix(ci): fix ESLint E2Es failing since v9 release ci: fix ESLint E2Es failing since v9 release Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcanis arcanis Awaiting requested review from arcanis arcanis is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wojtekmaj @merceyz @arcanis