Skip to content

Feature/py3 run#114

Open
rachmadaniHaryono wants to merge 28 commits intoyask123:masterfrom
rachmadaniHaryono:feature/py3-run
Open

Feature/py3 run#114
rachmadaniHaryono wants to merge 28 commits intoyask123:masterfrom
rachmadaniHaryono:feature/py3-run

Conversation

@rachmadaniHaryono
Copy link

@rachmadaniHaryono rachmadaniHaryono commented Feb 28, 2017

hi, i add test for this program along with some modification. here are the list of change that not shown on commit.

  • test
  • change in travis setting
    • add pandoc and python-eyed3
    • disable python2.6 and 3.2
      • python2.6: python -m flake8 not working.
      • python3.2: eyed3 is not working on travis-ci
  • change bin/instantmusic script: use simple python main function call. the code there is moved to proper place and tested.
  • change setup.cfg and setup.py: put them on root project folder.
  • package
    • add requirements-dev.txt for testing
    • add required package for program (eyed3, request)
  • program
    • simplify query_and_download : move part of the code to subfunction
    • rename makeRequest to make_request
    • catch error on python3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments