Added 10 Second Timeout, abort on error, and PEP'd some lines#66
Open
jvasallo wants to merge 3 commits intoyask123:masterfrom
Open
Added 10 Second Timeout, abort on error, and PEP'd some lines#66jvasallo wants to merge 3 commits intoyask123:masterfrom
jvasallo wants to merge 3 commits intoyask123:masterfrom
Conversation
- Cleaned up unused or repeated imports - Some PEP8 Clean Up - Long Term Fix is to call youtube_dl explicity
41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that if my connection would die out, it would never really fail leaving my terminal hanging. I could abort it, but I put a 10.0 second timeout and an abort on error.
We might need to look long term into implementing the youtube_dl module directly for better error handling however. For now, this should work.