Revert "Modifying requests to work with proxy"#96
Open
hut8 wants to merge 2 commits intoyask123:masterfrom
Open
Revert "Modifying requests to work with proxy"#96hut8 wants to merge 2 commits intoyask123:masterfrom
hut8 wants to merge 2 commits intoyask123:masterfrom
Conversation
Contributor
Author
|
Whoops, please don't merge yet -- I just realized that this is also the commit which removed the requirement for |
Contributor
Author
|
OK, fixed. |
This reverts commit d16899d.
hut8
force-pushed
the
lb/revert-requests-proxy
branch
from
48a7e43 to
a3c87b4
Compare
Contributor
Author
|
|
41 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d16899d.
Reason:
I'm not sure why this was necessary in the first place, but this commit: kennethreitz/requests@0ba8c44 has been included in Requests since v0.12.1 in 2012, which transparently adds the same stuff but accounts for more cases. For example, it handles
NO_PROXYcorrectly, and there are other places that allow forhttp_proxyinstead ofHTTP_PROXYto work. So this commit actually introduces some bugs, and in general just makes the API of requests a harder to use. I found this was redundant while trying to add a parameter to requests (specifically,payload=), so it's making a refactor (plus several character encoding / Py3K fixes) more difficult.