fix: remove hardcoded DB credentials and debug prints#1
Open
yassinsolim wants to merge 2 commits intomainfrom
Open
fix: remove hardcoded DB credentials and debug prints#1yassinsolim wants to merge 2 commits intomainfrom
yassinsolim wants to merge 2 commits intomainfrom
Conversation
- Replace hardcoded USER/PASS/URL with System.getenv() lookups - DB_PASSWORD defaults to empty string (not old hardcoded value) - Comment out System.out.println debug calls in production files - Improve .gitignore Security audit finding — credentials were committed to public repo.
Owner
Author
QA Re-run (audit)Result: ❌ FAIL (env/tooling) Commands run
Key checks
|
Owner
Author
QA Re-run (audit) — corrected summaryResult: ❌ FAIL (tooling unavailable in runner) Commands run
Key checks
|
Owner
Author
|
Audit follow-up completed on What I changed
Validation run
Notes: Maven is not available in this environment ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes hardcoded database credentials from public source code and cleans up debug output.
Changes
Validation
Risks / Notes
oop/ucalgarycredentials should be rotated if ever used on a real DBDB_USER=oop DB_PASSWORD=ucalgaryin environment or.envfile (not committed)Security audit finding — credentials were committed to public repo.