Conversation
The plugin fetched the full users.list snapshot before opening its socket, so a 429 anywhere on that client stalled the connection and, under the background ownership protocol, the whole cohort's readiness behind it. The snapshot is a cache that every consumer already loads lazily, so the plugin now connects first and warms the directory in the background. The integration fixture waits for that warm-up before tests inspect the published directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
startSlackPluginfetched the fullusers.listsnapshot before opening the socket. The@slack/web-apiclient pauses its whole request queue on a 429, so a rate limit anywhere on that client stalled the connection. Under the background ownership protocol the controller marks a replica ready only after its Slack runtimes have reconciled, so the stall also held back the whole cohort's readiness and, in a blue/green deployment, the promotion behind it. Observed on a production cohort: containers listening, then several minutes of silence, then the Slack connection and readiness arriving together.What
getUserSnapshotis a cache with in-flight dedupe thatclassifyUserCachedand the directory sync already load lazily, and its refresh already swallows errors, so nothing observable changes except that startup no longer waits for the walk.users.listpage is requested, and the walk still completes.Verification
node --test test/slack-index.integration.test.ts test/slack-runtime.test.ts test/background-controller.test.ts test/group-dm-open.test.tspasses (93 tests),tsc --noEmitandeslintclean on the changed files.