Conversation
An operator registers an overlay/custom/gateway provider precisely because those models are the ones they want reached, and picker order follows catalog order, so models an admin added should not sit below ~230 built-ins. Built-in ids still shadow a colliding custom id at resolution, so this changes ordering only.
jgatlit
force-pushed
the
fix/wire-custom-model-providers
branch
from
September 19, 2026 09:52
010408d to
15685c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom-provider store is built and returned by buildApp, but src/index.ts enumerates server deps explicitly and never passed it through, so every /v1/admin/custom-providers route hit its
if (!ctx.deps.customProviders) return 404guard — the feature was unreachable in a running core. Verified live: 404 -> 200 after the two-line fix.\n\nAlso orders admin-registered custom models ahead of built-ins in the catalog, since picker order follows catalog order and an operator registers a provider precisely because those models are the ones they want reached. Built-in ids still shadow a colliding custom id at resolution, so this changes ordering only.\n\ntsc --noEmit clean; model-registry, pi-models and webui-model-allowlist suites pass (23/23).