Skip to content

fix(VDiskPage): display params in 2 columns, change order #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025

Conversation

artemmufazalov
Copy link
Member

@artemmufazalov artemmufazalov commented Jun 24, 2025

Closes #1136

Display in 2 columns, change order. Params were not changed

Before:
Screenshot 2025-06-30 at 14 27 39

After:
Screenshot 2025-06-30 at 14 27 16

CI Results

Test Status: ⚠️ FLAKY

📊 Full Report

Total Passed Failed Flaky Skipped
354 348 0 1 5
Test Changes Summary ⏭️3

⏭️ Skipped Tests (3)

  1. Query tab first row has values for all columns in Top mode (tenant/diagnostics/tabs/queries.test.ts)
  2. Scroll to row, get shareable link, navigate to URL and verify row is scrolled into view (tenant/diagnostics/tabs/queries.test.ts)
  3. TopShards tab first row has values for all columns in History mode (tenant/diagnostics/tabs/topShards.test.ts)

Bundle Size: ✅

Current: 84.01 MB | Main: 84.01 MB
Diff: +1.29 KB (0.00%)

✅ Bundle size unchanged.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@artemmufazalov artemmufazalov changed the title fix(VDiskPage): display params in 2 columns fix(VDiskPage): display params in 2 columns, change order Jun 30, 2025
@artemmufazalov artemmufazalov marked this pull request as ready for review June 30, 2025 11:28
@artemmufazalov artemmufazalov added this pull request to the merge queue Jun 30, 2025
Merged via the queue into main with commit 2e0f203 Jun 30, 2025
9 checks passed
@artemmufazalov artemmufazalov deleted the 1136-vdisk-2-columns branch June 30, 2025 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display VDisk params in two columns similar to PDiskPage
2 participants