Add equals() and hashCode() methods to topic description classes #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dependent on the #476 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #480 +/- ##
============================================
- Coverage 58.71% 58.27% -0.45%
+ Complexity 2182 2179 -3
============================================
Files 323 323
Lines 13071 13167 +96
Branches 1278 1318 +40
============================================
- Hits 7675 7673 -2
- Misses 4774 4871 +97
- Partials 622 623 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Eistern
force-pushed
the
feature/equals-hashcode-for-descriptions
branch
from
6f3d0f5 to
51f5f5e
Compare
alex268
reviewed
May 13, 2025
|
|
||
| @Override | ||
| public boolean equals(Object o) { | ||
| if (o == null || getClass() != o.getClass()) { |
There was a problem hiding this comment.
Every equals implementation must start with
if (this == o) {
return true;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces proper equals() and hashCode() implementations to classes used during topic description operations. These implementations follow standard Java equality contract patterns and allow for reliable comparison of description objects.