Skip to content

Added api for session id of topic readers #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2025

Conversation

alex268
Copy link
Member

@alex268 alex268 commented May 12, 2025

No description provided.

@alex268 alex268 requested a review from pnv1 May 12, 2025 09:39
@codecov-commenter
Copy link

codecov-commenter commented May 12, 2025

Codecov Report

Attention: Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.

Project coverage is 58.73%. Comparing base (c96dfe7) to head (39931b3).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...java/tech/ydb/topic/read/impl/AsyncReaderImpl.java 62.50% 3 Missing ⚠️
.../java/tech/ydb/topic/read/impl/SyncReaderImpl.java 75.00% 1 Missing ⚠️
...db/topic/read/impl/events/SessionStartedEvent.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #481      +/-   ##
============================================
+ Coverage     58.71%   58.73%   +0.01%     
- Complexity     2179     2184       +5     
============================================
  Files           324      325       +1     
  Lines         13071    13089      +18     
  Branches       1278     1278              
============================================
+ Hits           7675     7688      +13     
- Misses         4773     4778       +5     
  Partials        623      623              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alex268 alex268 force-pushed the update_commit_offsets branch from e8c7fc5 to cb0356b Compare May 15, 2025 08:32
@alex268 alex268 force-pushed the update_commit_offsets branch from cb0356b to 39931b3 Compare May 15, 2025 09:34
@alex268 alex268 merged commit 7ee0b08 into ydb-platform:master May 15, 2025
10 checks passed
@alex268 alex268 deleted the update_commit_offsets branch May 15, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants