Skip to content

Fixed double compression of one message#504

Merged
alex268 merged 2 commits intoydb-platform:masterfrom
alex268:master
Jun 14, 2025
Merged

Fixed double compression of one message#504
alex268 merged 2 commits intoydb-platform:masterfrom
alex268:master

Conversation

@alex268
Copy link
Copy Markdown
Member

@alex268 alex268 commented Jun 10, 2025

Fixes #501

@alex268 alex268 requested a review from pnv1 June 10, 2025 13:44
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 10, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.35%. Comparing base (4822d6e) to head (2cb5c87).
⚠️ Report is 116 commits behind head on master.

Files with missing lines Patch % Lines
...ain/java/tech/ydb/topic/write/impl/WriterImpl.java 60.60% 8 Missing and 5 partials ⚠️
...ava/tech/ydb/topic/write/impl/EnqueuedMessage.java 75.00% 8 Missing and 2 partials ⚠️
...ic/src/main/java/tech/ydb/topic/write/Message.java 0.00% 1 Missing and 1 partial ⚠️
.../java/tech/ydb/topic/write/impl/MessageSender.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #504      +/-   ##
============================================
+ Coverage     59.31%   59.35%   +0.04%     
+ Complexity     2223     2219       -4     
============================================
  Files           327      327              
  Lines         13449    13433      -16     
  Branches       1338     1334       -4     
============================================
- Hits           7977     7973       -4     
+ Misses         4868     4860       -8     
+ Partials        604      600       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread topic/src/main/java/tech/ydb/topic/write/impl/EnqueuedMessage.java Outdated
Comment thread topic/src/main/java/tech/ydb/topic/write/impl/EnqueuedMessage.java Outdated
Comment thread topic/src/main/java/tech/ydb/topic/write/impl/EnqueuedMessage.java Outdated

public boolean isCompressed() {
return isCompressed.get();
this.originLength = bytes.length;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

originalSize?

@alex268 alex268 merged commit eb21d71 into ydb-platform:master Jun 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double sending of topic message creates double comporessed data

3 participants