Skip to content

Values comparison #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

zinal
Copy link
Member

@zinal zinal commented Jul 30, 2025

Added the Value<?> comparison support to facilitate the future KeyRange.contains() feature.

@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2025

Codecov Report

❌ Patch coverage is 32.41590% with 221 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.81%. Comparing base (af5f970) to head (85785c5).

Files with missing lines Patch % Lines
...ain/java/tech/ydb/table/values/PrimitiveValue.java 26.92% 35 Missing and 3 partials ⚠️
.../main/java/tech/ydb/table/values/DecimalValue.java 7.89% 22 Missing and 13 partials ⚠️
...src/main/java/tech/ydb/table/values/DictValue.java 48.00% 17 Missing and 9 partials ⚠️
...src/main/java/tech/ydb/table/values/ListValue.java 37.14% 15 Missing and 7 partials ⚠️
...c/main/java/tech/ydb/table/values/StructValue.java 37.14% 15 Missing and 7 partials ⚠️
...rc/main/java/tech/ydb/table/values/TupleValue.java 37.14% 15 Missing and 7 partials ⚠️
.../main/java/tech/ydb/table/values/VariantValue.java 29.03% 15 Missing and 7 partials ⚠️
...src/main/java/tech/ydb/table/values/NullValue.java 7.69% 9 Missing and 3 partials ⚠️
...src/main/java/tech/ydb/table/values/VoidValue.java 7.69% 9 Missing and 3 partials ⚠️
...main/java/tech/ydb/table/values/OptionalValue.java 60.00% 6 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #521      +/-   ##
============================================
- Coverage     61.29%   60.81%   -0.48%     
- Complexity     2306     2365      +59     
============================================
  Files           328      328              
  Lines         13468    13795     +327     
  Branches       1344     1437      +93     
============================================
+ Hits           8255     8390     +135     
- Misses         4577     4705     +128     
- Partials        636      700      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants