Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing spec columns #16061

Merged
merged 2 commits into from
Mar 22, 2025
Merged

fix missing spec columns #16061

merged 2 commits into from
Mar 22, 2025

Conversation

swalrus1
Copy link
Collaborator

@swalrus1 swalrus1 commented Mar 21, 2025 •
edited
Loading

  • fix missing spec columns
  • unmute test

Changelog entry

Init spec columns if they are needed for program execution in PLAIN reader

Changelog category

  • Bugfix

Description for reviewers

#16034

@swalrus1 swalrus1 marked this pull request as ready for review March 21, 2025 12:16
@swalrus1 swalrus1 requested a review from a team as a code owner March 21, 2025 12:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2025 •
edited
Loading

🟢 2025-03-21 12:50:18 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2025 •
edited
Loading

⚪ 2025-03-21 12:48:13 UTC Pre-commit check linux-x86_64-release-asan for 2963689 has started.
⚪ 2025-03-21 12:48:39 UTC Artifacts will be uploaded here
⚪ 2025-03-21 12:51:58 UTC ya make is running...
🟡 2025-03-21 14:02:23 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12008 11871 0 75 27 35

⚪ 2025-03-21 14:03:31 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-21 14:15:55 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
182 (only retried tests) 143 0 4 1 34

⚪ 2025-03-21 14:16:04 UTC ya make is running... (failed tests rerun, try 3)

@github-actions github-actions bot added bugfix and removed bugfix labels Mar 21, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2025 •
edited
Loading

⚪ 2025-03-21 12:50:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2963689 has started.
⚪ 2025-03-21 12:50:48 UTC Artifacts will be uploaded here
⚪ 2025-03-21 12:54:14 UTC ya make is running...
🟡 2025-03-21 13:50:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19303 17957 0 4 1233 109

⚪ 2025-03-21 13:52:17 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-21 14:06:23 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
159 (only retried tests) 52 0 1 0 106

⚪ 2025-03-21 14:06:36 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-21 14:19:48 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
148 (only retried tests) 40 0 2 0 106

🟢 2025-03-21 14:19:57 UTC Build successful.
🟢 2025-03-21 14:20:17 UTC ydbd size 2.2 GiB changed* by -12.9 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 6dc2e21 merge: 2963689 diff diff %
ydbd size 2 314 348 712 Bytes 2 314 335 480 Bytes -12.9 KiB -0.001%
ydbd stripped size 484 361 728 Bytes 484 362 112 Bytes +384 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 linked an issue Mar 21, 2025 that may be closed by this pull request
VERIFY in test_ttl_delete: (ui32)result->num_columns() == columnNames.size(); #16034
Closed
@swalrus1 swalrus1 added the rebase-and-check Rebase PR with the current base branch and check label Mar 21, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Mar 21, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2025 •
edited
Loading

⚪ 2025-03-21 14:38:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 3b1aa31 has started.
⚪ 2025-03-21 14:38:44 UTC Artifacts will be uploaded here
⚪ 2025-03-21 14:41:53 UTC ya make is running...
🟢 2025-03-21 15:41:09 UTC ydbd size 2.2 GiB changed* by +24.2 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 331ebd5 merge: 3b1aa31 diff diff %
ydbd size 2 315 393 280 Bytes 2 315 418 016 Bytes +24.2 KiB +0.001%
ydbd stripped size 484 582 752 Bytes 484 585 376 Bytes +2.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2025 •
edited
Loading

⚪ 2025-03-21 14:39:13 UTC Pre-commit check linux-x86_64-release-asan for 3b1aa31 has started.
⚪ 2025-03-21 14:39:48 UTC Artifacts will be uploaded here
⚪ 2025-03-21 14:43:04 UTC ya make is running...
🟢 2025-03-21 15:54:48 UTC ydbd size 3.8 GiB changed* by +35.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 331ebd5 merge: 3b1aa31 diff diff %
ydbd size 4 075 664 496 Bytes 4 075 701 216 Bytes +35.9 KiB +0.001%
ydbd stripped size 1 409 660 072 Bytes 1 409 669 352 Bytes +9.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 added the rebase-and-check Rebase PR with the current base branch and check label Mar 21, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Mar 21, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2025 •
edited
Loading

⚪ 2025-03-21 19:10:31 UTC Pre-commit check linux-x86_64-release-asan for 83b39ed has started.
⚪ 2025-03-21 19:10:54 UTC Artifacts will be uploaded here
⚪ 2025-03-21 19:13:44 UTC ya make is running...
🟡 2025-03-21 20:33:36 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12022 11925 0 50 11 36

⚪ 2025-03-21 20:34:50 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-21 20:47:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
146 (only retried tests) 100 0 5 7 34

⚪ 2025-03-21 20:48:09 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-21 21:00:25 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
76 (only retried tests) 33 0 4 6 33

🟢 2025-03-21 21:00:34 UTC Build successful.
🟢 2025-03-21 21:01:03 UTC ydbd size 3.8 GiB changed* by -19.5 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: 82e9e8d merge: 83b39ed diff diff %
ydbd size 4 080 049 072 Bytes 4 080 029 120 Bytes -19.5 KiB -0.000%
ydbd stripped size 1 409 686 632 Bytes 1 409 687 592 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

⚪ 2025-03-21 19:11:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for 83b39ed has started.

@swalrus1 swalrus1 added the rebase-and-check Rebase PR with the current base branch and check label Mar 22, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Mar 22, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2025 •
edited
Loading

⚪ 2025-03-22 08:11:06 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2c5de07 has started.
⚪ 2025-03-22 08:11:21 UTC Artifacts will be uploaded here
⚪ 2025-03-22 08:14:05 UTC ya make is running...
🟡 2025-03-22 09:11:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19318 17971 0 3 1230 114

⚪ 2025-03-22 09:13:14 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-22 09:25:54 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 53 0 0 0 109

🟢 2025-03-22 09:26:01 UTC Build successful.
🟠 2025-03-22 09:26:18 UTC Unmuted 1 tests
🟡 2025-03-22 09:26:37 UTC ydbd size 2.2 GiB changed* by +642.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 82e9e8d merge: 2c5de07 diff diff %
ydbd size 2 318 997 664 Bytes 2 319 655 832 Bytes +642.7 KiB +0.028%
ydbd stripped size 484 805 344 Bytes 484 932 096 Bytes +123.8 KiB +0.026%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 22, 2025 •
edited
Loading

⚪ 2025-03-22 08:11:07 UTC Pre-commit check linux-x86_64-release-asan for 2c5de07 has started.
⚪ 2025-03-22 08:11:21 UTC Artifacts will be uploaded here
⚪ 2025-03-22 08:14:02 UTC ya make is running...
🟡 2025-03-22 09:25:13 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12022 11889 0 85 9 39

⚪ 2025-03-22 09:26:26 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-22 09:38:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
188 (only retried tests) 149 0 3 3 33

⚪ 2025-03-22 09:39:02 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-22 09:51:08 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
66 (only retried tests) 29 0 4 1 32

🟢 2025-03-22 09:51:17 UTC Build successful.
🟡 2025-03-22 09:51:45 UTC ydbd size 3.8 GiB changed* by +972.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 82e9e8d merge: 2c5de07 diff diff %
ydbd size 4 080 049 072 Bytes 4 081 045 112 Bytes +972.7 KiB +0.024%
ydbd stripped size 1 409 686 632 Bytes 1 410 038 024 Bytes +343.2 KiB +0.025%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@swalrus1 swalrus1 merged commit 58fbe04 into ydb-platform:main Mar 22, 2025
30 of 37 checks passed
@swalrus1 swalrus1 deleted the init-spec-if-needed branch March 22, 2025 21:35
dorooleg pushed a commit to dorooleg/ydb that referenced this pull request Mar 24, 2025
@swalrus1 @dorooleg
fix missing spec columns (ydb-platform#16061)
992d032
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
@swalrus1
fix missing spec columns (ydb-platform#16061)
15aa7a2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorooleg dorooleg dorooleg approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VERIFY in test_ttl_delete: (ui32)result->num_columns() == columnNames.size();
2 participants
@swalrus1 @dorooleg