Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EnableConfigV2 option to allow enabling/disabling v2 configuration for migration purposes #16066

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Add EnableConfigV2 option to allow enabling/disabling v2 configuration for migration purposes #16066

merged 1 commit into from
Mar 25, 2025

Conversation

alexvru
Copy link
Collaborator

@alexvru alexvru commented Mar 21, 2025

Changelog entry

Add EnableConfigV2 option to allow enabling/disabling v2 configuration for migration purposes

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Support for explicit migration between v1 and v2 configurations through BSC.

@github-actions GitHub Actions
Copy link

🟢 2025-03-21 15:05:07 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2025 •
edited
Loading

⚪ 2025-03-21 15:05:38 UTC Pre-commit check linux-x86_64-release-asan for 4346a6c has started.
⚪ 2025-03-21 15:05:53 UTC Artifacts will be uploaded here
⚪ 2025-03-21 15:09:03 UTC ya make is running...
⚫ 2025-03-21 15:21:17 UTC Check cancelled

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2025 •
edited
Loading

⚪ 2025-03-21 15:15:31 UTC Pre-commit check linux-x86_64-relwithdebinfo for 4346a6c has started.
⚪ 2025-03-21 15:15:36 UTC Artifacts will be uploaded here
⚪ 2025-03-21 15:18:45 UTC ya make is running...
⚫ 2025-03-21 15:21:18 UTC Check cancelled

@alexvru alexvru force-pushed the bsdc/add-support-for-enabling-v2-config branch from 545c55a to 3c662a1 Compare March 21, 2025 15:20
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2025 •
edited
Loading

⚪ 2025-03-21 15:23:35 UTC Pre-commit check linux-x86_64-release-asan for 2e61d50 has started.
⚪ 2025-03-21 15:24:06 UTC Artifacts will be uploaded here
⚪ 2025-03-21 15:27:47 UTC ya make is running...
🟡 2025-03-21 17:03:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14621 14537 0 30 16 38

⚪ 2025-03-21 17:04:44 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-21 17:24:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
123 (only retried tests) 83 0 3 3 34

⚪ 2025-03-21 17:24:52 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-21 17:39:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
68 (only retried tests) 30 0 3 2 33

🟢 2025-03-21 17:39:38 UTC Build successful.
🟡 2025-03-21 17:40:09 UTC ydbd size 3.8 GiB changed* by +112.6 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 331ebd5 merge: 2e61d50 diff diff %
ydbd size 4 075 664 496 Bytes 4 075 779 848 Bytes +112.6 KiB +0.003%
ydbd stripped size 1 409 660 072 Bytes 1 409 690 696 Bytes +29.9 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 21, 2025 •
edited
Loading

⚪ 2025-03-21 15:24:17 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2e61d50 has started.
⚪ 2025-03-21 15:24:42 UTC Artifacts will be uploaded here
⚪ 2025-03-21 15:28:21 UTC ya make is running...
🟡 2025-03-21 17:05:53 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
29109 26499 0 3 2492 115

⚪ 2025-03-21 17:08:35 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-21 17:25:55 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 51 0 2 0 109

⚪ 2025-03-21 17:26:08 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-03-21 17:40:34 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
150 (only retried tests) 43 0 2 0 105

🟢 2025-03-21 17:40:44 UTC Build successful.
🟢 2025-03-21 17:41:04 UTC ydbd size 2.2 GiB changed* by +36.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: a95ce0d merge: 2e61d50 diff diff %
ydbd size 2 315 431 248 Bytes 2 315 469 072 Bytes +36.9 KiB +0.002%
ydbd stripped size 484 584 992 Bytes 484 590 624 Bytes +5.5 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru force-pushed the bsdc/add-support-for-enabling-v2-config branch from 3c662a1 to 7165e68 Compare March 25, 2025 09:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

⚪ 2025-03-25 09:21:35 UTC Pre-commit check linux-x86_64-release-asan for ae059c1 has started.
⚪ 2025-03-25 09:22:36 UTC Artifacts will be uploaded here
⚪ 2025-03-25 09:26:10 UTC ya make is running...
🟡 2025-03-25 11:16:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14171 14057 0 63 13 38

⚪ 2025-03-25 11:18:07 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-25 11:32:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
162 (only retried tests) 117 0 4 10 31

⚪ 2025-03-25 11:33:02 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-25 11:45:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
71 (only retried tests) 35 0 4 1 31

🟢 2025-03-25 11:46:05 UTC Build successful.
🟢 2025-03-25 11:46:34 UTC ydbd size 3.8 GiB changed* by +54.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8bc6d81 merge: ae059c1 diff diff %
ydbd size 4 083 458 048 Bytes 4 083 514 296 Bytes +54.9 KiB +0.001%
ydbd stripped size 1 410 951 272 Bytes 1 410 974 984 Bytes +23.2 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 25, 2025 •
edited
Loading

⚪ 2025-03-25 09:21:55 UTC Pre-commit check linux-x86_64-relwithdebinfo for ae059c1 has started.
⚪ 2025-03-25 09:22:10 UTC Artifacts will be uploaded here
⚪ 2025-03-25 09:25:21 UTC ya make is running...
🟡 2025-03-25 11:07:54 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28706 26040 0 6 2547 113

⚪ 2025-03-25 11:10:35 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-25 11:28:52 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
171 (only retried tests) 59 0 0 6 106

🟢 2025-03-25 11:29:02 UTC Build successful.
🟢 2025-03-25 11:29:24 UTC ydbd size 2.2 GiB changed* by +37.4 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8bc6d81 merge: ae059c1 diff diff %
ydbd size 2 321 217 720 Bytes 2 321 255 976 Bytes +37.4 KiB +0.002%
ydbd stripped size 485 295 360 Bytes 485 304 320 Bytes +8.8 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@alexvru alexvru marked this pull request as ready for review March 25, 2025 10:57
@alexvru alexvru requested a review from a team as a code owner March 25, 2025 10:57
@alexvru alexvru enabled auto-merge (squash) March 25, 2025 10:57
@alexvru alexvru merged commit 9808a23 into ydb-platform:main Mar 25, 2025
12 checks passed
@alexvru alexvru deleted the bsdc/add-support-for-enabling-v2-config branch March 25, 2025 12:00
@Enjection Enjection mentioned this pull request Mar 26, 2025
Merged
Enjection pushed a commit to Enjection/ydb that referenced this pull request Mar 26, 2025
@alexvru @Enjection
Add EnableConfigV2 option to allow enabling/disabling v2 configuratio…
afec64e 
…n for migration purposes (ydb-platform#16066)
@Enjection Enjection mentioned this pull request Mar 26, 2025
Merged
Enjection pushed a commit to Enjection/ydb that referenced this pull request Mar 26, 2025
@alexvru @Enjection
Add EnableConfigV2 option to allow enabling/disabling v2 configuratio…
e13dad4 
…n for migration purposes (ydb-platform#16066)
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 28, 2025
@alexvru
Add EnableConfigV2 option to allow enabling/disabling v2 configuratio…
365abc3 
…n for migration purposes (ydb-platform#16066)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kruall kruall kruall approved these changes

@Gazizonoki Gazizonoki Gazizonoki approved these changes

Assignees
No one assigned
Labels
not-for-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexvru @kruall @Gazizonoki