Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set field Engine to 1 to maintain backward compatibility (#15878) #16073

Open
wants to merge 1 commit into
base: stable-25-1-1
Choose a base branch
from

Conversation

aavdonkin
Copy link
Collaborator

@aavdonkin aavdonkin commented Mar 21, 2025

Changelog entry

Initialize field Engine before write to local database, to make possible to work by branch stable-24-3-15

Changelog category

  • Bugfix

Description for reviewers

...

@aavdonkin aavdonkin requested a review from a team as a code owner March 21, 2025 17:18
Copy link

github-actions bot commented Mar 21, 2025

2025-03-21 17:19:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 41be5cf has started.
2025-03-21 17:19:45 UTC Artifacts will be uploaded here
2025-03-21 17:23:42 UTC ya make is running...
🟡 2025-03-21 19:11:00 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28089 25487 0 4 2463 135

2025-03-21 19:13:53 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-21 19:34:42 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
209 (only retried tests) 76 0 0 4 129

🟢 2025-03-21 19:34:49 UTC Build successful.
🟢 2025-03-21 19:35:08 UTC ydbd size 2.1 GiB changed* by +15.7 KiB, which is < 100.0 KiB vs stable-25-1-1: OK

ydbd size dash stable-25-1-1: 0115065 merge: 41be5cf diff diff %
ydbd size 2 242 407 112 Bytes 2 242 423 192 Bytes +15.7 KiB +0.001%
ydbd stripped size 474 916 952 Bytes 474 917 912 Bytes +960 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 21, 2025

2025-03-21 17:23:05 UTC Pre-commit check linux-x86_64-release-asan for 41be5cf has started.
2025-03-21 17:23:20 UTC Artifacts will be uploaded here
2025-03-21 17:26:44 UTC ya make is running...
🟡 2025-03-21 19:14:22 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13828 13752 0 31 11 34

2025-03-21 19:15:36 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-21 19:36:19 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
117 (only retried tests) 83 0 1 1 32

2025-03-21 19:36:27 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-21 19:56:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
61 (only retried tests) 27 0 1 1 32

🟢 2025-03-21 19:56:28 UTC Build successful.
🟢 2025-03-21 19:56:55 UTC ydbd size 3.6 GiB changed* by +27.2 KiB, which is < 100.0 KiB vs stable-25-1-1: OK

ydbd size dash stable-25-1-1: 0115065 merge: 41be5cf diff diff %
ydbd size 3 900 702 336 Bytes 3 900 730 144 Bytes +27.2 KiB +0.001%
ydbd stripped size 1 365 201 200 Bytes 1 365 205 936 Bytes +4.6 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Collaborator

@maximyurchuk maximyurchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Из описания " make possible to work by branch stable-24-3-15" -- мы не поддерживаем совместимость с 24-3 в этой ветке

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants