Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default value has been disabled for column tables #16088

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dorooleg
Copy link
Collaborator

@dorooleg dorooleg commented Mar 22, 2025

Changelog entry

Первым шагом запрещаем использование default колонок в колоночных таблицах, в этом ревью запрет при создании колоночных таблиц

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

Copy link

github-actions bot commented Mar 22, 2025

🟢 2025-03-24 06:43:29 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 22, 2025

2025-03-22 14:56:53 UTC Pre-commit check linux-x86_64-release-asan for 9ca8470 has started.
2025-03-22 14:57:08 UTC Artifacts will be uploaded here
2025-03-22 14:59:59 UTC ya make is running...
🟡 2025-03-22 16:13:40 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12146 12033 0 53 24 36

2025-03-22 16:14:44 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-22 16:32:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
161 (only retried tests) 109 0 8 7 37

2025-03-22 16:32:13 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-22 16:43:58 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
81 (only retried tests) 36 0 2 8 35

🟢 2025-03-22 16:44:05 UTC Build successful.
🟢 2025-03-22 16:44:36 UTC ydbd size 3.8 GiB changed* by +18.9 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 79a448f merge: 9ca8470 diff diff %
ydbd size 4 081 231 344 Bytes 4 081 250 712 Bytes +18.9 KiB +0.000%
ydbd stripped size 1 410 077 256 Bytes 1 410 082 312 Bytes +4.9 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 22, 2025

2025-03-22 15:44:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9ca8470 has started.
2025-03-22 15:44:37 UTC Artifacts will be uploaded here
2025-03-22 15:47:24 UTC ya make is running...
🟡 2025-03-22 16:45:30 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19656 18275 0 10 1245 126

2025-03-22 16:47:11 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-22 16:59:29 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
188 (only retried tests) 76 0 1 0 111

2025-03-22 16:59:39 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-22 17:11:51 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
153 (only retried tests) 44 0 0 0 109

🟢 2025-03-22 17:11:58 UTC Build successful.
🟢 2025-03-22 17:12:18 UTC ydbd size 2.2 GiB changed* by +6.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 79a448f merge: 9ca8470 diff diff %
ydbd size 2 319 786 000 Bytes 2 319 792 672 Bytes +6.5 KiB +0.000%
ydbd stripped size 484 953 632 Bytes 484 954 976 Bytes +1.3 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dorooleg dorooleg force-pushed the default_value_disabled branch from 6032c0d to df17d99 Compare March 26, 2025 09:51
Copy link

github-actions bot commented Mar 26, 2025

2025-03-26 09:53:03 UTC Pre-commit check linux-x86_64-relwithdebinfo for db45bfc has started.
2025-03-26 09:53:19 UTC Artifacts will be uploaded here
2025-03-26 09:56:02 UTC ya make is running...
🟡 2025-03-26 11:07:06 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
19696 18337 0 9 1241 109

2025-03-26 11:08:58 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-26 11:27:11 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
165 (only retried tests) 66 0 0 0 99

🟢 2025-03-26 11:27:21 UTC Build successful.
🟢 2025-03-26 11:27:41 UTC ydbd size 2.2 GiB changed* by +6.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0f63d39 merge: db45bfc diff diff %
ydbd size 2 342 739 520 Bytes 2 342 746 256 Bytes +6.6 KiB +0.000%
ydbd stripped size 489 885 440 Bytes 489 886 848 Bytes +1.4 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 26, 2025

2025-03-26 09:53:03 UTC Pre-commit check linux-x86_64-release-asan for db45bfc has started.
2025-03-26 09:53:18 UTC Artifacts will be uploaded here
2025-03-26 09:56:05 UTC ya make is running...
🟡 2025-03-26 11:27:41 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12163 12088 0 30 11 34

2025-03-26 11:28:48 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-26 11:45:09 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
115 (only retried tests) 74 0 5 6 30

2025-03-26 11:45:20 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-26 11:57:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
67 (only retried tests) 28 0 4 6 29

🟢 2025-03-26 11:57:54 UTC Build successful.
🟢 2025-03-26 11:58:23 UTC ydbd size 3.8 GiB changed* by +19.0 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 0f63d39 merge: db45bfc diff diff %
ydbd size 4 110 533 368 Bytes 4 110 552 792 Bytes +19.0 KiB +0.000%
ydbd stripped size 1 420 393 896 Bytes 1 420 399 016 Bytes +5.0 KiB +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Поддержать default значения колонок для колоночных таблиц
1 participant