Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client timeout histogram for grpc call metrics. (#16065) #16231

Open
wants to merge 1 commit into
base: stable-25-1
Choose a base branch
from

Conversation

dcherednik
Copy link
Member

In case of investigation problems with unexpected timeout response It is helpful to know actual timeout for grpc call from the server perspective

In case of investigation problems with unexpected timeout response It is helpful to know actual timeout for grpc call from the server perspective
@dcherednik dcherednik requested a review from a team as a code owner March 25, 2025 17:40
Copy link

🟢 2025-03-25 17:41:19 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Mar 25, 2025

2025-03-25 17:41:25 UTC Pre-commit check linux-x86_64-release-asan for b08dfbb has started.
2025-03-25 17:41:45 UTC Artifacts will be uploaded here
2025-03-25 17:45:00 UTC ya make is running...
🟡 2025-03-25 19:12:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13720 13580 0 99 5 36

2025-03-25 19:14:20 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-25 19:35:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
185 (only retried tests) 152 0 0 1 32

🟢 2025-03-25 19:35:47 UTC Build successful.
🟢 2025-03-25 19:36:13 UTC ydbd size 3.6 GiB changed* by +45.0 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 2b365ce merge: b08dfbb diff diff %
ydbd size 3 902 599 200 Bytes 3 902 645 328 Bytes +45.0 KiB +0.001%
ydbd stripped size 1 365 732 240 Bytes 1 365 759 248 Bytes +26.4 KiB +0.002%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 25, 2025

2025-03-25 17:43:39 UTC Pre-commit check linux-x86_64-relwithdebinfo for b08dfbb has started.
2025-03-25 17:43:54 UTC Artifacts will be uploaded here
2025-03-25 17:47:00 UTC ya make is running...
🟡 2025-03-25 19:05:52 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27952 25348 0 6 2465 133

2025-03-25 19:08:24 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-25 19:29:30 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
213 (only retried tests) 78 0 0 5 130

🟢 2025-03-25 19:29:37 UTC Build successful.
🟢 2025-03-25 19:29:57 UTC ydbd size 2.1 GiB changed* by +14.0 KiB, which is < 100.0 KiB vs stable-25-1: OK

ydbd size dash stable-25-1: 2b365ce merge: b08dfbb diff diff %
ydbd size 2 243 406 640 Bytes 2 243 420 960 Bytes +14.0 KiB +0.001%
ydbd stripped size 475 085 944 Bytes 475 090 872 Bytes +4.8 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik enabled auto-merge (squash) March 27, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant