Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --no-discovery option to YDB cli #16266

Merged
merged 1 commit into from
Apr 1, 2025
Merged

Add --no-discovery option to YDB cli #16266

merged 1 commit into from
Apr 1, 2025
+26 −0

Conversation

dcherednik
Copy link
Member

@dcherednik dcherednik commented Mar 26, 2025 •
edited
Loading

Changelog entry

"--no-discovery" option allows to skip discovery and use user provided endpoint to connect to YDB cluster.

Changelog category

  • New feature

Description for reviewers

In case where network of YDB has access outside only via some balancer client load balancing is not effective.

@dcherednik dcherednik requested a review from a team as a code owner March 26, 2025 11:21
@dcherednik dcherednik changed the title Add --no-discovery option. Add --no-discovery option to YDB cli Mar 26, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2025 •
edited
Loading

🟢 2025-04-01 13:26:18 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2025 •
edited
Loading

⚪ 2025-03-26 11:23:08 UTC Pre-commit check linux-x86_64-release-asan for 5cf2c47 has started.
⚪ 2025-03-26 11:23:11 UTC Artifacts will be uploaded here
⚪ 2025-03-26 11:26:05 UTC ya make is running...
🟡 2025-03-26 12:43:21 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12390 12294 0 47 15 34

⚪ 2025-03-26 12:44:38 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-26 13:00:57 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
141 (only retried tests) 101 0 4 3 33

⚪ 2025-03-26 13:01:09 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-26 13:13:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
65 (only retried tests) 28 0 4 2 31

🟢 2025-03-26 13:13:31 UTC Build successful.
🟢 2025-03-26 13:14:02 UTC ydbd size 3.8 GiB changed* by +64 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 22ccfe5 merge: 5cf2c47 diff diff %
ydbd size 4 110 540 160 Bytes 4 110 540 224 Bytes +64 Bytes +0.000%
ydbd stripped size 1 420 396 008 Bytes 1 420 396 072 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2025 •
edited
Loading

⚪ 2025-03-26 11:23:08 UTC Pre-commit check linux-x86_64-relwithdebinfo for 5cf2c47 has started.
⚪ 2025-03-26 11:23:12 UTC Artifacts will be uploaded here
⚪ 2025-03-26 11:26:04 UTC ya make is running...
🟡 2025-03-26 12:36:27 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26892 24226 0 5 2547 114

⚪ 2025-03-26 12:39:26 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-26 12:55:21 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
172 (only retried tests) 67 0 1 0 104

⚪ 2025-03-26 12:55:33 UTC ya make is running... (failed tests rerun, try 3)
🟢 2025-03-26 13:09:49 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
145 (only retried tests) 45 0 0 0 100

🟢 2025-03-26 13:10:00 UTC Build successful.
🟢 2025-03-26 13:10:23 UTC ydbd size 2.2 GiB changed* by +16 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 22ccfe5 merge: 5cf2c47 diff diff %
ydbd size 2 342 731 376 Bytes 2 342 731 392 Bytes +16 Bytes +0.000%
ydbd stripped size 489 884 928 Bytes 489 884 928 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2025 •
edited
Loading

⚪ 2025-03-26 14:03:57 UTC Pre-commit check linux-x86_64-release-asan for 8df1fa9 has started.
⚪ 2025-03-26 14:04:26 UTC Artifacts will be uploaded here
⚪ 2025-03-26 14:07:46 UTC ya make is running...
🟡 2025-03-26 15:23:48 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12395 12302 0 45 14 34

⚪ 2025-03-26 15:25:16 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-26 15:39:47 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
137 (only retried tests) 93 0 5 9 30

⚪ 2025-03-26 15:39:59 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-26 16:01:15 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
69 (only retried tests) 32 0 6 1 30

🟢 2025-03-26 16:01:25 UTC Build successful.
🟡 2025-03-26 16:01:54 UTC ydbd size 3.8 GiB changed* by +221.7 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 22ccfe5 merge: 8df1fa9 diff diff %
ydbd size 4 110 540 160 Bytes 4 110 767 152 Bytes +221.7 KiB +0.006%
ydbd stripped size 1 420 396 008 Bytes 1 420 472 936 Bytes +75.1 KiB +0.005%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 26, 2025 •
edited
Loading

⚪ 2025-03-26 14:04:01 UTC Pre-commit check linux-x86_64-relwithdebinfo for 8df1fa9 has started.
⚪ 2025-03-26 14:04:17 UTC Artifacts will be uploaded here
⚪ 2025-03-26 14:07:14 UTC ya make is running...
🟡 2025-03-26 15:20:36 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26897 24068 0 171 2545 113

⚪ 2025-03-26 15:23:12 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-26 15:35:48 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
336 (only retried tests) 229 0 0 7 100

🟢 2025-03-26 15:35:59 UTC Build successful.
🟡 2025-03-26 15:36:19 UTC ydbd size 2.2 GiB changed* by +107.2 KiB, which is >= 100.0 KiB vs main: Warning

ydbd size dash main: 22ccfe5 merge: 8df1fa9 diff diff %
ydbd size 2 342 731 376 Bytes 2 342 841 160 Bytes +107.2 KiB +0.005%
ydbd stripped size 489 884 928 Bytes 489 905 216 Bytes +19.8 KiB +0.004%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

pnv1
pnv1 previously approved these changes Mar 26, 2025
View reviewed changes
@dcherednik
Add --no-discovery option.
baccf61 
It allows to skip discovery and use user provided endpoint
to connect to YDB cluster.
@dcherednik dcherednik force-pushed the cli_option_to_skip_discovery branch from 596197f to baccf61 Compare April 1, 2025 14:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2025 •
edited
Loading

⚪ 2025-04-01 14:25:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for ba970f3 has started.
⚪ 2025-04-01 14:25:34 UTC Artifacts will be uploaded here
⚪ 2025-04-01 14:28:32 UTC ya make is running...
🟡 2025-04-01 15:47:56 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26881 24208 0 13 2546 114

⚪ 2025-04-01 15:50:31 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-01 16:13:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
178 (only retried tests) 71 0 5 0 102

⚪ 2025-04-01 16:13:46 UTC ya make is running... (failed tests rerun, try 3)
🔴 2025-04-01 16:28:07 UTC Some tests failed, follow the links below.

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
149 (only retried tests) 46 0 1 0 102

🟢 2025-04-01 16:28:19 UTC Build successful.
🟢 2025-04-01 16:28:40 UTC ydbd size 2.2 GiB changed* by +96 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 04d730d merge: ba970f3 diff diff %
ydbd size 2 350 152 960 Bytes 2 350 153 056 Bytes +96 Bytes +0.000%
ydbd stripped size 491 575 904 Bytes 491 575 968 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2025 •
edited
Loading

⚪ 2025-04-01 14:26:11 UTC Pre-commit check linux-x86_64-release-asan for ba970f3 has started.
⚪ 2025-04-01 14:26:26 UTC Artifacts will be uploaded here
⚪ 2025-04-01 14:29:25 UTC ya make is running...
🟡 2025-04-01 15:48:12 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12453 12296 0 86 35 36

⚪ 2025-04-01 15:49:24 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-01 16:13:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
212 (only retried tests) 129 0 38 14 31

⚪ 2025-04-01 16:13:31 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-01 16:25:26 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
114 (only retried tests) 49 0 33 3 29

🟢 2025-04-01 16:25:36 UTC Build successful.
🟢 2025-04-01 16:26:09 UTC ydbd size 3.8 GiB changed* by -64 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: 04d730d merge: ba970f3 diff diff %
ydbd size 4 123 641 568 Bytes 4 123 641 504 Bytes -64 Bytes -0.000%
ydbd stripped size 1 425 040 168 Bytes 1 425 040 168 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik enabled auto-merge (squash) April 1, 2025 17:17
@dcherednik dcherednik added the rebase-and-check Rebase PR with the current base branch and check label Apr 1, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Apr 1, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2025 •
edited
Loading

⚪ 2025-04-01 17:22:29 UTC Pre-commit check linux-x86_64-relwithdebinfo for 1e62ec5 has started.
⚪ 2025-04-01 17:22:46 UTC Artifacts will be uploaded here
⚪ 2025-04-01 17:25:31 UTC ya make is running...
🟡 2025-04-01 18:31:47 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
26885 24219 0 2 2546 118

⚪ 2025-04-01 18:34:11 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-04-01 18:45:12 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
172 (only retried tests) 69 0 0 0 103

🟢 2025-04-01 18:45:22 UTC Build successful.
🟢 2025-04-01 18:45:42 UTC ydbd size 2.2 GiB changed* by +32 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4cd260f merge: 1e62ec5 diff diff %
ydbd size 2 350 309 368 Bytes 2 350 309 400 Bytes +32 Bytes +0.000%
ydbd stripped size 491 615 520 Bytes 491 615 520 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2025 •
edited
Loading

⚪ 2025-04-01 17:22:53 UTC Pre-commit check linux-x86_64-release-asan for 1e62ec5 has started.
⚪ 2025-04-01 17:23:08 UTC Artifacts will be uploaded here
⚪ 2025-04-01 17:26:05 UTC ya make is running...
🟡 2025-04-01 18:46:11 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
12456 12244 0 130 38 44

⚪ 2025-04-01 18:47:16 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-04-01 19:00:18 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
264 (only retried tests) 180 0 34 16 34

⚪ 2025-04-01 19:00:30 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-04-01 19:13:29 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
113 (only retried tests) 40 0 33 8 32

🟢 2025-04-01 19:13:39 UTC Build successful.
🟢 2025-04-01 19:14:15 UTC ydbd size 3.8 GiB changed* by +16 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4cd260f merge: 1e62ec5 diff diff %
ydbd size 4 123 986 648 Bytes 4 123 986 664 Bytes +16 Bytes +0.000%
ydbd stripped size 1 425 155 176 Bytes 1 425 155 240 Bytes +64 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dcherednik dcherednik merged commit 2e2ded0 into ydb-platform:main Apr 1, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pnv1 pnv1 pnv1 approved these changes

Assignees
No one assigned
Labels
new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcherednik @pnv1