Skip to content

Conversation

kruall
Copy link
Collaborator

@kruall kruall commented Apr 2, 2025

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

Add arm build targets and remove s3 arguments

@kruall kruall added the area/blobstorage BlobStorage issues label Apr 2, 2025
@kruall kruall requested review from kobzonega and Copilot April 2, 2025 08:18
@kruall kruall self-assigned this Apr 2, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the build workflow for YDB DSTool. It adds ARM build targets, clarifies build inputs and artifact naming for different platforms, and removes legacy S3 input parameters in favor of hardcoded environment variables.

Comments suppressed due to low confidence (3)

.github/workflows/build_ydb_dstool.yml:93

  • Ensure that renaming the Windows build target to 'windows-amd' aligns consistently with all occurrences in the workflow and that no stray references to the old 'windows' target remain.
if: ${{ matrix.os == 'windows-amd' }}

.github/workflows/build_ydb_dstool.yml:185

  • Review the hardcoded S3 environment variables to ensure they accurately reflect the desired configuration now that the dynamic S3 inputs have been removed.
env:
          S3_HOST: "storage.yandexcloud.net"
          S3_BUCKET: "yandexcloud-ydb-dstool"
          S3_DNS_HOST_BUCKET: "%(bucket)s.storage.yandexcloud.net"
          S3_REGION: ru-central1

.github/workflows/build_ydb_dstool.yml:6

  • [nitpick] Consider adding inline documentation for 'commit_sha' to clarify its usage in checking out the repository for version determination, ensuring consistency with the other inputs.
commit_sha:

Copy link

github-actions bot commented Apr 2, 2025

🟢 2025-04-02 08:19:34 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented Apr 2, 2025

2025-04-02 08:20:59 UTC Pre-commit check linux-x86_64-release-asan for 7c3eeab has started.
2025-04-02 08:21:28 UTC Artifacts will be uploaded here
2025-04-02 08:24:12 UTC ya make is running...
🟢 2025-04-02 08:24:18 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-02 08:24:24 UTC Build successful.

@kruall kruall requested review from maximyurchuk and removed request for kobzonega April 2, 2025 08:21
Copy link

github-actions bot commented Apr 2, 2025

2025-04-02 08:22:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7c3eeab has started.
2025-04-02 08:22:29 UTC Artifacts will be uploaded here
2025-04-02 08:24:48 UTC ya make is running...
🟢 2025-04-02 08:24:53 UTC Tests successful.

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-04-02 08:24:59 UTC Build successful.

@kruall kruall merged commit aa051c8 into ydb-platform:main Apr 2, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants