Remove NYT::CreateStdErrLogger method from query_replay_yt #18445
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
⚪ Test history | Ya make output | Test bloat
🟢 |
|
🟢 |
|
⚪ Test history | Ya make output | Test bloat
🟢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog entry
Remove
NYT::CreateStdErrLoggersinceNYT::Initializealready sets up the logger.Changelog category
Description for reviewers
This PR refactors the existing logging setup by removing the use of
CreateStdErrLogger, which will soon be obsolete.NYT::Initializeis already handling logger setup directly, makingCreateStdErrLoggerredundant.You probably have to set desired
LogLevelconfig option before callingNYT::Initialize, if it is differs from the default (error) log level.This change is also in alignment with the wider refactoring of the logging system within yt/cpp. Please refer to ytsaurus/ytsaurus@8956fc5