Skip to content

fq/checkpoint storage: enable more query caching #18453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yumkam
Copy link
Collaborator

@yumkam yumkam commented May 18, 2025

add placeholders in more queries and propagate query settings into TGenerationContext

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

YQ-4303

add placeholders and enable caching
Copy link

github-actions bot commented May 18, 2025

🟢 2025-05-18 14:01:01 UTC The validation of the Pull Request description is successful.

Copy link

github-actions bot commented May 18, 2025

2025-05-18 10:08:26 UTC Pre-commit check linux-x86_64-release-asan for c1582ee has started.
2025-05-18 10:08:36 UTC Artifacts will be uploaded here
2025-05-18 10:11:22 UTC ya make is running...
🟡 2025-05-18 11:42:54 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13138 12994 0 76 39 29

2025-05-18 11:44:00 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-05-18 12:13:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1235 (only retried tests) 1153 0 49 9 24

2025-05-18 12:13:59 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-05-18 12:40:38 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
1030 (only retried tests) 942 0 48 18 22

🟢 2025-05-18 12:40:48 UTC Build successful.
🟢 2025-05-18 12:41:22 UTC ydbd size 3.9 GiB changed* by -47.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: dee22ec merge: c1582ee diff diff %
ydbd size 4 141 785 720 Bytes 4 141 737 584 Bytes -47.0 KiB -0.001%
ydbd stripped size 1 437 649 848 Bytes 1 437 639 992 Bytes -9.6 KiB -0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented May 18, 2025

2025-05-18 10:08:37 UTC Pre-commit check linux-x86_64-relwithdebinfo for c1582ee has started.
2025-05-18 10:08:51 UTC Artifacts will be uploaded here
2025-05-18 10:11:44 UTC ya make is running...
🟡 2025-05-18 11:22:31 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
27828 25133 0 3 2654 38

2025-05-18 11:24:46 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-05-18 11:48:47 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
131 (only retried tests) 87 0 0 11 33

🟢 2025-05-18 11:48:53 UTC Build successful.
🟢 2025-05-18 11:49:16 UTC ydbd size 2.2 GiB changed* by -10.0 KiB, which is <= 0 Bytes vs main: OK

ydbd size dash main: dee22ec merge: c1582ee diff diff %
ydbd size 2 354 367 768 Bytes 2 354 357 512 Bytes -10.0 KiB -0.000%
ydbd stripped size 494 719 752 Bytes 494 719 432 Bytes -320 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@yumkam yumkam marked this pull request as ready for review May 18, 2025 13:55
@yumkam yumkam requested a review from a team as a code owner May 18, 2025 13:55
@yumkam yumkam changed the title fq/checkpoint storage: cache Register query fq/checkpoint storage: enable more query caching May 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant