Skip to content

Fix data race on Checksumming field in TGroupSessions (#26096) #26231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
Merged

Fix data race on Checksumming field in TGroupSessions (#26096) #26231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ydb/core/blobstorage/dsproxy/group_sessions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ TGroupSessions::TGroupSessions(const TIntrusivePtr<TBlobStorageGroupInfo>& info,
auto& q = stateVDisk.Queues.GetQueue(queueId);
q.ActorId = queue;
q.FlowRecord = std::move(flowRecord);
q.ExtraBlockChecksSupport.reset();
q.ExtraBlockChecksSupport.store(false);
}
}
}
Expand Down Expand Up @@ -128,17 +128,17 @@ void TGroupSessions::QueueConnectUpdate(ui32 orderNumber, NKikimrBlobStorage::EV

if (connected) {
ConnectedQueuesMask[orderNumber] |= 1 << queueId;
q.ExtraBlockChecksSupport = extraGroupChecksSupport;
q.Checksumming = checksumming;
q.ExtraBlockChecksSupport.store(extraGroupChecksSupport);
q.Checksumming.store(checksumming);
Y_ABORT_UNLESS(costModel);
if (!q.CostModel || *q.CostModel != *costModel) {
updated = true;
q.CostModel = costModel;
}
} else {
ConnectedQueuesMask[orderNumber] &= ~(1 << queueId);
q.ExtraBlockChecksSupport.reset();
q.Checksumming.reset();
q.ExtraBlockChecksSupport.store(false);
q.Checksumming.store(false);
if (q.CostModel) {
updated = true;
q.CostModel = nullptr;
Expand Down
18 changes: 15 additions & 3 deletions ydb/core/blobstorage/dsproxy/group_sessions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,20 @@ namespace NKikimr {
struct TQueue {
TActorId ActorId;
TIntrusivePtr<NBackpressure::TFlowRecord> FlowRecord;
std::optional<bool> ExtraBlockChecksSupport;
std::optional<bool> Checksumming;
struct AtomicParameter : public std::atomic<bool> {
AtomicParameter& operator=(const AtomicParameter& other) {
store(other.load());
return *this;
}

AtomicParameter(const AtomicParameter& other) {
store(other.load());
}

AtomicParameter() {
store(false);
}
} ExtraBlockChecksSupport, Checksumming;
std::shared_ptr<const TCostModel> CostModel = nullptr;
volatile bool IsConnected = false;
};
Expand Down Expand Up @@ -190,7 +202,7 @@ namespace NKikimr {
.Queues
.GetQueue(queueId)
.Checksumming
.value_or(false);
.load();
}

ui64 GetPredictedDelayNsByOrderNumber(ui32 orderNumber, NKikimrBlobStorage::EVDiskQueueId queueId) {
Expand Down
Loading