- 
                Notifications
    You must be signed in to change notification settings 
- Fork 727
verify has been changed to error #27614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| 🟢  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces runtime verification with error handling for duplicate entity IDs. The changes add context to existing assertions and introduce proactive duplicate detection to prevent runtime failures.
- Enhanced AFL_VERIFYassertions with entity_id context for better debugging
- Added duplicate entity ID detection before insertion into collections
- Converts potential runtime failures into explicit error messages
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description | 
|---|---|
| ydb/core/tx/columnshard/engines/reader/common_reader/iterator/fetched_data.cpp | Added entity_id context to AFL_VERIFY assertions in AddFetchers and AddFetcher methods | 
| ydb/core/formats/arrow/program/original.cpp | Introduced uniqueEntityIds tracking to detect and prevent duplicate entity IDs across data, index, and header processing | 
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ⚪  ⚪  Ya make output | Test bloat | Test bloat 
 🟢  
 *please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation | 
| ⚪  
 🟢  
 *please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation | 
Changelog entry
...
Changelog category
Description for reviewers
...