Skip to content

Conversation

@dorooleg
Copy link
Collaborator

Changelog entry

...

Changelog category

  • Not for changelog (changelog entry is not required)

Description for reviewers

...

@dorooleg dorooleg requested a review from a team as a code owner October 26, 2025 14:42
@github-actions
Copy link

🟢 2025-10-26 14:42:32 UTC The validation of the Pull Request description is successful.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces runtime verification with error handling for duplicate entity IDs. The changes add context to existing assertions and introduce proactive duplicate detection to prevent runtime failures.

  • Enhanced AFL_VERIFY assertions with entity_id context for better debugging
  • Added duplicate entity ID detection before insertion into collections
  • Converts potential runtime failures into explicit error messages

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ydb/core/tx/columnshard/engines/reader/common_reader/iterator/fetched_data.cpp Added entity_id context to AFL_VERIFY assertions in AddFetchers and AddFetcher methods
ydb/core/formats/arrow/program/original.cpp Introduced uniqueEntityIds tracking to detect and prevent duplicate entity IDs across data, index, and header processing

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 26, 2025

2025-10-26 14:44:53 UTC Pre-commit check linux-x86_64-relwithdebinfo for b7d1a96 has started.
2025-10-26 14:45:08 UTC Artifacts will be uploaded here
2025-10-26 14:48:35 UTC ya make is running...
🟡 2025-10-26 16:19:33 UTC Some tests failed, follow the links below. Going to retry failed tests...

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
39144 36345 0 7 2765 27

2025-10-26 16:19:44 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-10-26 16:39:03 UTC Tests successful.

Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
629 (only retried tests) 608 0 0 0 21

🟢 2025-10-26 16:39:06 UTC Build successful.
🟢 2025-10-26 16:39:21 UTC ydbd size 2.3 GiB changed* by +16.5 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: fd2cb7b merge: b7d1a96 diff diff %
ydbd size 2 437 356 520 Bytes 2 437 373 368 Bytes +16.5 KiB +0.001%
ydbd stripped size 518 133 704 Bytes 518 136 392 Bytes +2.6 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions
Copy link

github-actions bot commented Oct 26, 2025

2025-10-26 14:47:32 UTC Pre-commit check linux-x86_64-release-asan for b7d1a96 has started.
2025-10-26 14:47:47 UTC Artifacts will be uploaded here
2025-10-26 14:50:48 UTC ya make is running...
🟡 2025-10-26 16:56:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
15607 15022 0 304 257 24

🟢 2025-10-26 16:56:11 UTC Build successful.
🟢 2025-10-26 16:56:34 UTC ydbd size 3.8 GiB changed* by +27.7 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: fd2cb7b merge: b7d1a96 diff diff %
ydbd size 4 055 777 320 Bytes 4 055 805 672 Bytes +27.7 KiB +0.001%
ydbd stripped size 1 506 056 128 Bytes 1 506 066 496 Bytes +10.1 KiB +0.001%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@dorooleg dorooleg requested a review from Vladilen October 26, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant