Skip to content

Docs: lock statistics to KQP query metrics #30611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
azevaykin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Docs: lock statistics to KQP query metrics #30611

azevaykin wants to merge 1 commit into from
+26 −0

Conversation

@azevaykin
Copy link
Collaborator

@azevaykin azevaykin commented Dec 12, 2025

Changelog entry

Documentation for #30268

Changelog category

  • Documentation (changelog entry is not required)

Description for reviewers

...

Copilot AI review requested due to automatic review settings December 12, 2025 12:12
@azevaykin azevaykin requested a review from a team as a code owner December 12, 2025 12:12
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 12, 2025
Copilot AI reviewed Dec 12, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds documentation for lock statistics metrics in KQP query metrics system views. The changes document two new metrics that track broken locks from both the breaker and victim perspectives.

Key Changes:

  • Added documentation for LocksBrokenAsBreaker and LocksBrokenAsVictim metrics
  • Included clarifying notes about which lock-breaking scenarios are excluded from these statistics

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
ydb/docs/ru/core/dev/system-views.md Added Russian documentation for lock statistics metrics with exclusions note
ydb/docs/en/core/dev/system-views.md Added English documentation for lock statistics metrics with exclusions note

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

⚪ 2025-12-12 12:14:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2a7b24c has started.
⚪ 2025-12-12 12:14:26 UTC Artifacts will be uploaded here
⚪ 2025-12-12 12:16:32 UTC ya make is running...
🟢 2025-12-12 12:16:37 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-12-12 12:16:42 UTC Build successful.

@ydbot
Copy link
Collaborator

ydbot commented Dec 12, 2025

Run Extra Tests

Run additional tests for this PR. You can customize:

  • Test Size: small, medium, large (default: all)
  • Test Targets: any directory path (default: ydb/)
  • Sanitizers: ASAN, MSAN, TSAN
  • Coredumps: enable for debugging (default: off)
  • Additional args: custom ya make arguments

▶ Run tests

@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

⚪ 2025-12-12 12:15:08 UTC Pre-commit check linux-x86_64-release-asan for 2a7b24c has started.
⚪ 2025-12-12 12:15:46 UTC Artifacts will be uploaded here
⚪ 2025-12-12 12:17:46 UTC ya make is running...
🟢 2025-12-12 12:17:52 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-12-12 12:17:57 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

🟢 2025-12-12 12:15:32 UTC The validation of the Pull Request description is successful.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

✅ Documentation build

Revision built successfully
Revision preview link

Build logs

Warnings (6)

⚠️ Incorrect syntax for notes, file ru/devops/observability/alerting.md

⚠️ Skip error: SkippedEvalError: Cannot apply an unsupported filter: ansible_config_file | dirname

⚠️ Variable ansible_config_file | dirname not found in ru/devops/deployment-options/ansible/initial-deployment.md

⚠️ en/dev/system-views.md: 237: MD032 / blanks-around-lists Lists should be surrounded by blank lines [Context: "- Locks broken due to schema c..."]

⚠️ ru/dev/system-views.md: 237: MD032 / blanks-around-lists Lists should be surrounded by blank lines [Context: "- Блокировки, сломанные из-за ..."]

⚠️ ru/reference/ydb-cli/topic-consumer-add.md: 35: MD001 / heading-increment Heading levels should only increment by one level at a time [Expected: h3; Actual: h4]

snaury
snaury previously approved these changes Dec 12, 2025
View reviewed changes
@azevaykin azevaykin requested a review from snaury December 12, 2025 12:55
@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

⚪ 2025-12-12 12:55:55 UTC Pre-commit check linux-x86_64-release-asan for cebcfa5 has started.
⚪ 2025-12-12 12:56:43 UTC Artifacts will be uploaded here
⚪ 2025-12-12 12:58:32 UTC ya make is running...
🟢 2025-12-12 12:58:38 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-12-12 12:58:43 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

⚪ 2025-12-12 12:56:13 UTC Pre-commit check linux-x86_64-relwithdebinfo for cebcfa5 has started.
⚪ 2025-12-12 12:56:48 UTC Artifacts will be uploaded here
⚪ 2025-12-12 12:58:58 UTC ya make is running...
🟢 2025-12-12 12:59:04 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-12-12 12:59:10 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

✅ Documentation build

Revision built successfully
Revision preview link

Build logs

Warnings (6)

⚠️ Incorrect syntax for notes, file ru/devops/observability/alerting.md

⚠️ Skip error: SkippedEvalError: Cannot apply an unsupported filter: ansible_config_file | dirname

⚠️ Variable ansible_config_file | dirname not found in ru/devops/deployment-options/ansible/initial-deployment.md

⚠️ en/dev/system-views.md: 237: MD032 / blanks-around-lists Lists should be surrounded by blank lines [Context: "- Locks broken due to schema c..."]

⚠️ ru/dev/system-views.md: 237: MD032 / blanks-around-lists Lists should be surrounded by blank lines [Context: "- Блокировки, сломанные из-за ..."]

⚠️ ru/reference/ydb-cli/topic-consumer-add.md: 35: MD001 / heading-increment Heading levels should only increment by one level at a time [Expected: h3; Actual: h4]

@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

⚪ 2025-12-12 13:29:40 UTC Pre-commit check linux-x86_64-release-asan for 9c5c750 has started.
⚪ 2025-12-12 13:29:45 UTC Artifacts will be uploaded here
⚪ 2025-12-12 13:31:00 UTC ya make is running...
🟢 2025-12-12 13:31:06 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-12-12 13:31:11 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025 •
edited
Loading

⚪ 2025-12-12 13:30:23 UTC Pre-commit check linux-x86_64-relwithdebinfo for 9c5c750 has started.
⚪ 2025-12-12 13:30:42 UTC Artifacts will be uploaded here
⚪ 2025-12-12 13:32:57 UTC ya make is running...
🟢 2025-12-12 13:33:03 UTC Tests successful.

Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
0 0 0 0 0 0

🟢 2025-12-12 13:33:10 UTC Build successful.

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

✅ Documentation build

Revision built successfully
Revision preview link

Build logs

Warnings (4)

⚠️ Incorrect syntax for notes, file ru/devops/observability/alerting.md

⚠️ Skip error: SkippedEvalError: Cannot apply an unsupported filter: ansible_config_file | dirname

⚠️ Variable ansible_config_file | dirname not found in ru/devops/deployment-options/ansible/initial-deployment.md

⚠️ ru/reference/ydb-cli/topic-consumer-add.md: 35: MD001 / heading-increment Heading levels should only increment by one level at a time [Expected: h3; Actual: h4]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@snaury snaury snaury approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azevaykin @ydbot @snaury