Skip to content

EXT-1567 Require read rights (instead of read/write) for ListOperations/GetOperation API (#30556) #30641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
UgnineSirdis wants to merge 1 commit into
base: stream-nb-25-1
Choose a base branch
from
+10 −1
Open

EXT-1567 Require read rights (instead of read/write) for ListOperations/GetOperation API (#30556) #30641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ydb/core/grpc_services/rpc_get_operation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ using TEvGetOperationRequest = TGrpcRequestOperationCall<Ydb::Operations::GetOpe

class TGetOperationRPC : public TRpcOperationRequestActor<TGetOperationRPC, TEvGetOperationRequest, true>,
public TExportConv {
ui32 GetRequiredAccessRights() const override {
return NACLib::GenericRead;
}

TStringBuf GetLogPrefix() const override {
switch (OperationId_.GetKind()) {
Expand Down
3 changes: 3 additions & 0 deletions ydb/core/grpc_services/rpc_list_operations.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ using TEvListOperationsRequest = TGrpcRequestNoOperationCall<Ydb::Operations::Li

class TListOperationsRPC: public TRpcOperationRequestActor<TListOperationsRPC, TEvListOperationsRequest>,
public TExportConv {
ui32 GetRequiredAccessRights() const override {
return NACLib::GenericRead;
}

TStringBuf GetLogPrefix() const override {
switch (ParseKind(GetProtoRequest()->kind())) {
Expand Down
5 changes: 4 additions & 1 deletion ydb/core/grpc_services/rpc_operation_request_base.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,9 @@ class TRpcOperationRequestActor: public TRpcRequestActor<TDerived, TEvRequest, H
protected:
virtual TStringBuf GetLogPrefix() const = 0;
virtual IEventBase* MakeRequest() = 0;
virtual ui32 GetRequiredAccessRights() const {
return NACLib::GenericRead | NACLib::GenericWrite;
}

STATEFN(StateBase) {
switch (ev->GetTypeRewrite()) {
Expand Down Expand Up @@ -88,7 +91,7 @@ class TRpcOperationRequestActor: public TRpcRequestActor<TDerived, TEvRequest, H
}
}

if (!this->CheckAccess(CanonizePath(entry.Path), entry.SecurityObject, NACLib::GenericRead | NACLib::GenericWrite)) {
if (!this->CheckAccess(CanonizePath(entry.Path), entry.SecurityObject, GetRequiredAccessRights())) {
return;
}

Expand Down
Loading