Fix: Landing Page Layout Breaking Issues #118
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes critical layout breaking issues on the landing page by removing problematic scaling transforms and fixing overflow constraints. The changes ensure consistent rendering across all device sizes.
- Replaced
h-screen overflow-hiddenwithmin-h-screento prevent content overflow - Removed aggressive
scale-[]transforms that caused unpredictable layout behavior - Changed
w-screentow-fulland added proper max-width constraints
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| onClick={handleEnter} | ||
| disabled={isSignedUp} | ||
| className="bg-[#FFFB00] w-auto h-11 text-black font-silkscreen border border-black text-sm px-6 py-[9px] rounded-[6px] hover:scale-105 transition cursor-pointer disabled:opacity-50 disabled:cursor-not-allowed" | ||
| className="bg-[#FFFB00] whitespace-nowrap h-11 text-black font-silkscreen border border-black text-sm px-6 py-2 rounded-md hover:scale-105 transition cursor-pointer disabled:opacity-50 disabled:cursor-not-allowed" |
There was a problem hiding this comment.
The py-2 class should be py-[9px] to maintain the original vertical padding. The change from py-[9px] to py-2 (8px) reduces the button's internal padding, which may affect the visual consistency with the design.
Suggested change
| className="bg-[#FFFB00] whitespace-nowrap h-11 text-black font-silkscreen border border-black text-sm px-6 py-2 rounded-md hover:scale-105 transition cursor-pointer disabled:opacity-50 disabled:cursor-not-allowed" | |
| className="bg-[#FFFB00] whitespace-nowrap h-11 text-black font-silkscreen border border-black text-sm px-6 py-[9px] rounded-md hover:scale-105 transition cursor-pointer disabled:opacity-50 disabled:cursor-not-allowed" |
Author
|
@yep-yogesh kindly look into this pr and merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #86
Problem:
Changes:
✅ Fixed overflow issues by replacing h-screen overflow-hidden with min-h-screen
✅ Removed excessive scale-[] transforms that caused layout breaks
✅ Changed w-screen to w-full to prevent horizontal overflow
✅ Added proper max-width constraints for better content containment
✅ Improved responsive spacing and layout flow
Testing:
Files Changed:
Screenshots: (Before/After)
Before:
After: