Skip to content

easy access sni TLSSettings smart constructor#1025

Merged
kazu-yamamoto merged 5 commits intoyesodweb:masterfrom
tmcl:easy-access-sni
Mar 17, 2025
Merged

easy access sni TLSSettings smart constructor#1025
kazu-yamamoto merged 5 commits intoyesodweb:masterfrom
tmcl:easy-access-sni

Conversation

@tmcl
Copy link
Copy Markdown

@tmcl tmcl commented Mar 11, 2025

This implements my suggestion in our discussion in #859

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Comment thread warp-tls/Network/Wai/Handler/WarpTLS.hs Outdated
Comment thread warp-tls/Network/Wai/Handler/WarpTLS.hs Outdated
@tmcl tmcl force-pushed the easy-access-sni branch from c4390af to 465f607 Compare March 11, 2025 04:17
@kazu-yamamoto
Copy link
Copy Markdown
Contributor

kazu-yamamoto commented Mar 11, 2025

@tmcl Would you cherry-pick 06b3dd3 to this PR and update the reason for the pragma?

@tmcl
Copy link
Copy Markdown
Author

tmcl commented Mar 11, 2025

@tmcl Would you cherry-pick 06b3dd3 to this PR and update the reason for the pragma?

Done. Also version bump/changelog/since.

@kazu-yamamoto
Copy link
Copy Markdown
Contributor

@vdukhovni Would you review this PR?

@kazu-yamamoto
Copy link
Copy Markdown
Contributor

I recalled this issue: haskell-tls/hs-tls#479

@kazu-yamamoto kazu-yamamoto merged commit 1a9f8bb into yesodweb:master Mar 17, 2025
14 checks passed
@kazu-yamamoto
Copy link
Copy Markdown
Contributor

Merged and a new version has been released.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants