Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yesod-core: Relax dependency on cookie for tests #1857

Merged
merged 1 commit into from
Jan 27, 2025
Merged

yesod-core: Relax dependency on cookie for tests #1857

merged 1 commit into from
Jan 27, 2025

Conversation

DamienCassou
Copy link
Contributor

@DamienCassou DamienCassou commented Jan 25, 2025 •
edited
Loading

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@DamienCassou DamienCassou marked this pull request as ready for review January 25, 2025 16:50
@DamienCassou
Copy link
Contributor Author

This PR makes it easier to package yesod-core.

jezen
jezen approved these changes Jan 27, 2025
View reviewed changes
Copy link
Member

@jezen jezen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks Damien.

@jezen jezen merged commit 32b0d39 into yesodweb:master Jan 27, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jezen jezen jezen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DamienCassou @jezen