Skip to content

Monadic#10

Closed
treeowl wants to merge 3 commits into
ygale:masterfrom
treeowl:monadic
Closed

Monadic#10
treeowl wants to merge 3 commits into
ygale:masterfrom
treeowl:monadic

Conversation

@treeowl

@treeowl treeowl commented Jan 15, 2019

Copy link
Copy Markdown
Contributor

Use evaluate rather than seq to force the values to be stored. This feels right to me, but I'm not entirely confident it's the way to go.

@treeowl treeowl force-pushed the monadic branch 2 times, most recently from efd9068 to ea5e272 Compare January 15, 2019 23:37
@treeowl

treeowl commented Jan 15, 2019

Copy link
Copy Markdown
Contributor Author

@simonmar, do you have a moment to consider whether this is the right approach?

@treeowl

treeowl commented Jan 15, 2019

Copy link
Copy Markdown
Contributor Author

@simonmar, your attention is only requested for the second of the two commits.

@simonmar

Copy link
Copy Markdown

I have no context here, but if you're asking whether evaluate is better than seq in IO, then the answer is yes. (But I think you know that already...)

Comment thread Control/Concurrent/MVar/Strict.hs
Co-authored-by: ygale <gale@sefer.org>
@ygale ygale mentioned this pull request Jan 8, 2022
@ygale

ygale commented Jan 8, 2022

Copy link
Copy Markdown
Owner

We decided in the discussion of PR #9 to merge this PR now as is. I am doing this by copying the branch to my repo, creating a new PR #13 , and merging that instead. That way I do not have to bother @treeowl for silly administrative things I need to do before merging, like switching CI to github actions.

Note that I am switching to the now standard practice of running CI only for the most recent few versions of GHC. This fundamental library actually supports much more than that, including versions of base stretching back into ancient history. But none of that is actually supported by GHC team anymore, It may be difficult to find platforms on which we can test those versions nowadays even if we wanted to. Being untestable, we will probably deprecate and remove support for such ancient versions someday soon.

@ygale ygale closed this Jan 8, 2022
@treeowl

treeowl commented Jan 9, 2022

Copy link
Copy Markdown
Contributor Author

@ygale the way I see it, any GHC version not tested in CI is not actually supported. Either it should be added to CI, or the attempted support should be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants