Skip to content

Refactor tests - #414

Merged
vjik merged 8 commits into
masterfrom
refactor-test
Nov 20, 2025
Merged

vjik merged 8 commits into
masterfrom
refactor-test

Conversation

@vjik

@vjik vjik commented Nov 19, 2025

Copy link
Copy Markdown
Member
Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌

Related to yiisoft/db#1098

@vjik vjik mentioned this pull request Nov 19, 2025
@codecov

codecov Bot commented Nov 19, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (2105f63) to head (9a8a611).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #414   +/-   ##
=========================================
  Coverage     98.62%   98.62%           
  Complexity      247      247           
=========================================
  Files            26       26           
  Lines           800      800           
=========================================
  Hits            789      789           
  Misses           11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vjik
vjik requested a review from a team November 19, 2025 13:38
@vjik vjik added the status:code review The pull request needs review. label Nov 19, 2025
Comment thread tests/Type/BinaryTest.php Outdated
{
$this->setFixture('Type/binary.sql');
$db = $this->getSharedConnection();
$this->loadFixture(dirname(__DIR__) . '/Support/Fixture/Type/binary.sql');

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use default directory and pass only Type/binary.sql

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FixtureDump with constants is added.

@vjik
vjik requested a review from Tigrov November 20, 2025 12:54
@vjik
vjik merged commit 0f41835 into master Nov 20, 2025
20 of 21 checks passed
@vjik
vjik deleted the refactor-test branch November 20, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:code review The pull request needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants