Repository navigation
Refactor tests - #444
Merged
Merged
Refactor tests#444
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #444 +/- ##
============================================
- Coverage 98.83% 98.70% -0.13%
Complexity 252 252
============================================
Files 24 24
Lines 775 775
============================================
- Hits 766 765 -1
- Misses 9 10 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tigrov
approved these changes
Nov 20, 2025
| $db = $this->getConnection(); | ||
| $serverVersion = $db->getServerInfo()->getVersion(); | ||
| $db->close(); | ||
| $serverVersion = $this->getSharedConnection()->getServerInfo()->getVersion(); |
Member
There was a problem hiding this comment.
Maybe add new method $this->getServerVersion()?
Member
Author
There was a problem hiding this comment.
TestConnection::getServerVersion() is added.
Tigrov
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to yiisoft/db#1098