Skip to content

Improve phpdoc - #1161

Merged
samdark merged 5 commits into
masterfrom
improve-phpdoc
Feb 21, 2026
Merged

samdark merged 5 commits into
masterfrom
improve-phpdoc

Conversation

@samdark

@samdark samdark commented Feb 20, 2026

Copy link
Copy Markdown
Member
Q A
Is bugfix? ❌
New feature? ❌
Breaks BC? ❌
Tests pass? ✔️
Fixed issues -

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates PHPDoc wording in ConnectionInterface to improve clarity and consistency of method descriptions in the DB connection abstraction layer.

Changes:

  • Rephrases multiple method summaries/@return descriptions for more consistent and concise language.
  • Clarifies certain behaviors (e.g., savepoints, connection active state) via improved doc text.
  • Adjusts table prefix setter documentation to describe the mutator behavior more directly.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Connection/ConnectionInterface.php Outdated
@codecov

codecov Bot commented Feb 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.64%. Comparing base (b2b6eb0) to head (3a61c48).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1161      +/-   ##
============================================
- Coverage     98.62%   97.64%   -0.99%     
  Complexity     1645     1645              
============================================
  Files           120      120              
  Lines          4292     4285       -7     
============================================
- Hits           4233     4184      -49     
- Misses           59      101      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

@samdark I've opened a new pull request, #1162, to work on those changes. Once the pull request is ready, I'll request review from you.

@Tigrov Tigrov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Connection object acts also as a factory. Perhaps we should create a separate factory and move create...() methods there.

Comment thread src/Connection/ConnectionInterface.php Outdated
Comment thread src/Connection/ConnectionInterface.php Outdated
Comment thread src/Connection/ConnectionInterface.php Outdated
samdark and others added 3 commits February 22, 2026 00:01
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
Co-authored-by: Sergei Tigrov <rrr-r@ya.ru>
@samdark
samdark merged commit 7c7e290 into master Feb 21, 2026
44 of 68 checks passed
@samdark
samdark deleted the improve-phpdoc branch February 21, 2026 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants