Skip to content

Add mutex for saving process #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Add mutex for saving process #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
49f28e9
Add mutex for saving process
xepozz Jun 18, 2023
e1f3bda
Merge branch 'master' into mutex
xepozz Oct 14, 2023
45728db
Merge branch 'master' into mutex
xepozz Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"yiisoft/di": "^1.0",
"yiisoft/files": "^2.0",
"yiisoft/json": "^1.0",
"yiisoft/mutex": "^1.1",
"yiisoft/profiler": "^3.0",
"yiisoft/proxy": "^1.0.1",
"yiisoft/strings": "^2.2",
Expand Down
8 changes: 7 additions & 1 deletion src/Debugger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
namespace Yiisoft\Yii\Debug;

use Psr\Http\Message\ServerRequestInterface;
use Yiisoft\Mutex\Synchronizer;
use Yiisoft\Strings\WildcardPattern;
use Yiisoft\Yii\Console\Event\ApplicationStartup;
use Yiisoft\Yii\Debug\Collector\CollectorInterface;
Expand All @@ -13,12 +14,15 @@

final class Debugger
{
public const SAVING_MUTEX_NAME = self::class;

private bool $skipCollect = false;
private bool $active = false;

public function __construct(
private DebuggerIdGenerator $idGenerator,
private StorageInterface $target,
private Synchronizer $synchronizer,
/**
* @var CollectorInterface[]
*/
Expand Down Expand Up @@ -64,7 +68,9 @@ public function shutdown(): void

try {
if (!$this->skipCollect) {
$this->target->flush();
$this->synchronizer->execute(self::SAVING_MUTEX_NAME . $this->idGenerator->getId(), function () {
$this->target->flush();
});
}
} finally {
foreach ($this->collectors as $collector) {
Expand Down