Fix #211: Replace abandoned git wrapper#345
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR replaces the abandoned symplify/git-wrapper dependency with a small in-repo Git adapter built on symfony/process, and updates existing commands/components to use the new adapter for the Git operations needed by the dev tool.
Changes:
- Removed
symplify/git-wrapperfromcomposer.json. - Added an in-tree Git adapter (
GitWorkingCopy,GitBranches,GitTags,GitException) backed bySymfony\Component\Process\Process. - Updated package Git working copy creation and the contributors stats command to use the new adapter API.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/App/Component/Package/Package.php | Switches from GitWrapper to a local GitWorkingCopy instance using a discovered git binary. |
| src/App/Component/Git/GitWorkingCopy.php | New process-backed Git adapter (core implementation). |
| src/App/Component/Git/GitBranches.php | New helper for listing branches and determining HEAD. |
| src/App/Component/Git/GitTags.php | New helper for listing tags. |
| src/App/Component/Git/GitException.php | New exception type for adapter failures. |
| src/App/Command/Stats/ContributorsCommand.php | Uses the adapter to run git shortlog with structured args/options. |
| src/App/Command/Release/MakeCommand.php | Updates imports to the new GitWorkingCopy. |
| src/App/Command/Git/PushCommand.php | Updates exception import to the new GitException. |
| src/App/Command/AddChangelogCommand.php | Updates imports to the new GitWorkingCopy. |
| composer.json | Removes the abandoned symplify/git-wrapper dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #211.
Summary
Notes
Verification
No mutating dev-tool Git commands were run during verification.