super and initialize related cases#16
Open
handsomecheung wants to merge 2 commits into
Open
Conversation
1, `super` may refer to any methods, not only `initialize` 2, missing `popStack(call)` 3, `Class.new` always returns <Class> type, not same as `initialize`
yinwang0
approved these changes
Aug 14, 2019
Owner
|
I'm afraid I don't have time to verify RubySonar code any more. If you want merge this commit, please do a larger scale run first to avoid possible problems. |
Contributor
Author
|
I just test this change for some cases, so I am not sure if there are potential problems, especially for the method |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found some cases about
superandinitialize:supercan refer to any methods, not onlyinitializesupercan return a valid typeClass.newalways returns an instance of Class, not same asinitializemissing
popStack(call)if call
supertwice, the secondsuperwill returnType.UNKNOWNbecause the method whichsuperrefers to is still in stack.