Move reading of auth-public-key down from top level#27
Open
dyedwiper wants to merge 1 commit intoyjs:masterfrom
Open
Move reading of auth-public-key down from top level#27dyedwiper wants to merge 1 commit intoyjs:masterfrom
dyedwiper wants to merge 1 commit intoyjs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are currently trying to integrate y-redis in our app. Because the code in src/server.js is very specific, we have rewritten that part ourselves and imported registerYWebsocketServer directly from src/ws.js. We then encountered the problem that the app didn't start because AUTH_PUBLIC_KEY was not set though we didn't use it. It was because it is read on top level in src/server.js and this file is executed always because it is exported in index.js. I don't see a reason why it must be read on top-level. Moving it into the function should fix the problem.