-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Grab comments above global symbols and show them on hover #34
Feat: Grab comments above global symbols and show them on hover #34
Conversation
Looks very promising! The idea of this feature is extending the hover documentation functionality to variables not covered by the poky doc, mostly from community layers. The goal should not be to display all comments. We have the Go to definition feature for navigating definitions and related comments. A few comments:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
1,2: Done. |
6f5fd60
to
53a3550
Compare
53a3550
to
3d76325
Compare
3878293
to
627129e
Compare
Currently we don't bring .conf files to our recipes list so ignore them for now. Could become relevant when we have recipe-specific scan with the full include list. |
This PR adds the comments above the symbols (Variables and functions) defined in the global scope in the hover definition.


Sample results:
Show all comments in the current file and included files
The comments are appended at the end
Caveat:
The results won't reflect right after modifications on the comments in the included files because it needs to run
analyze()
to update the values. Currently, it needs additional input to trigger it.What I have in mind are these two:
analyze()
on the current file when the included files are modified.Despite the caveat, the feature itself is ready for review.