Feat: Add definitions for embedded languages #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deribaucourt
requested changes
Dec 26, 2023
idillon-sfl
force-pushed
the
add-embedded-definitions
branch
from
393e86d to
256ccde
Compare
deribaucourt
requested changes
Jan 3, 2024
idillon-sfl
force-pushed
the
add-embedded-definitions
branch
from
256ccde to
be6a417
Compare
deribaucourt
previously approved these changes
Jan 3, 2024
idillon-sfl
force-pushed
the
add-embedded-definitions
branch
from
be6a417 to
a27e95b
Compare
|
definition.test.ts and command-wrapper.test.ts were both opening meta-fixtures/definition.bb. For reasons that are not well understood, it was making the tests fail. Now they both open a different file. |
deribaucourt
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note some definitions do not work properly, such as the ones for the
utilsandcontainsparts ofbb.utils.contains. These are the sames the same for which hover is deffective.I tried something in order to handle
dande. I am not sure this is the desired behavior. Please tell me what you think of it.