Devtool ide sdk integration #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deribaucourt
force-pushed
the
devtool-ide-sdk
branch
7 times, most recently
from
6f40e60 to
24d8618
Compare
deribaucourt
force-pushed
the
devtool-ide-sdk
branch
2 times, most recently
from
a920053 to
c289258
Compare
This command allows to configure a devtool workspace for cross-compilation and debugging.
We don't provide a "Don't show again" option for this error, as it can only be started by explicit manual user action.
The SSH target configuration is now a single string instead of an object. We'll rely on the user's SSH configuration file to define additional options. devtool has other configs, but we may define them later if needed with a separate bitbake.sshOptions settings object
The new parameter for bitbake tasks will allow running devtool eSDK commands from external workspaces for application developpers. I would have preferred not exposing the use of such custom commands but writing the command assembly logic seems overkill here. The documentation states that this configuration is intended for internal use by the extension.
This command will allow users who don't have the `devtool ide-sdk` poky command, or use recipe classes which are not yet supported. The generated tasks.json will use `devtool build` and `devtool deploy-target` instead of `devtool ide-sdk`. This will be slower, and not provide advanced features such as debugging and linting, but will still allow users to build and deploy their recipes.
Our Jest tests usually take 2-3minutes so they timed out through the jest extension watcher.
This allows users to identify spawn errors because the workingDirectory is not set correctly.
This mode will disable the features using bitbake, but keep the devtool features enabled.
bitbake won't be available in eSDK mode. Disable some related features.
In eSDK mode, we don't have access to the full bitbake environment, but some features can still be useful with some adaptations.
Even though bitbake is available in these workspace's configurations, we don't want to do a bitbake scan and have bitbake features enabled.
The devtool build/clean commands replace bitbake in the case we are using an eSDK.
deribaucourt
force-pushed
the
devtool-ide-sdk
branch
from
c289258 to
caaed8d
Compare
idillon-sfl
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Sorry, I find this a bit hard to review. I am not very familiar with the behaviors of Devtool.
I am under the impression some "any" could have been avoidable, but at the same time I know this is the type returned by some used apis and I don't know what have been the challenges.
So I guess this is fine.
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.