2.6.0 by yogasw · Pull Request #147 · yogasw/beo-echo

yogasw · 2025-11-10T15:27:16Z

No description provided.

Update CHANGELOG.md for v2.5.3

…middleware

Features/actions

update pipelines

Copilot

Pull Request Overview

This PR introduces a comprehensive Actions feature (v2.6.0) that enables automated modification of requests and responses in the Beo Echo API mocking service. The implementation includes:

Two action types: Replace Text and Run JavaScript
Full CRUD operations with priority-based execution ordering
Filter system for conditional action execution
Integration with existing mock/proxy service pipeline
Complete frontend UI with drag-and-drop reordering

Key Changes

Backend: New actions module with service layer, repository, and two action types (replace_text, run_javascript)
Frontend: Complete Actions UI with wizards, forms, and interactive components
Infrastructure: Database migrations, middleware updates, and request ID tracking

Reviewed Changes

Copilot reviewed 43 out of 44 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
`backend/src/actions/`	Complete actions feature implementation with service, handler, and modules
`backend/src/database/models.go`	Added Action and ActionFilter models
`backend/src/database/repositories/action_repo.go`	Repository implementation with tests
`backend/src/echo/services/mock_service.go`	Integration of action execution in request pipeline
`backend/src/middlewares/logRequestId.go`	New middleware for request ID tracking
`frontend/src/lib/components/actions/`	Complete Actions UI components
`frontend/src/lib/api/actionsApi.ts`	Frontend API client for actions
`frontend/src/lib/types/Action.ts`	TypeScript type definitions
`docs/Actions_Documentation.md`	Comprehensive user guide

Copilot · 2025-11-10T15:32:05Z

frontend/src/lib/components/actions/modules/ReplaceText/ReplacetextItem.svelte

+			request_body: {
+				label: 'Response Body',
+				icon: 'fa-arrow-left',
+				color: 'text-green-500 dark:text-green-400'
+			},


The label for 'request_body' is incorrectly set to 'Response Body' - it should be 'Request Body'. This mislabeling will confuse users about which target they are actually modifying.

Copilot · 2025-11-10T15:32:06Z

backend/src/actions/modules/action_run_javascript.go

+
+// ValidateRunJavascriptConfig validates the configuration for run_javascript actions
+func (m *ModulesAction) ValidateRunJavascriptConfig(configJSON string) error {
+	// TODO : Implement actual validation logic if needed


The ValidateRunJavascriptConfig function is not implemented and always returns nil. This leaves JavaScript configurations unvalidated, potentially allowing invalid or malicious scripts through. At minimum, validate that the config is valid JSON and contains a non-empty 'script' field.

Suggested change

// TODO : Implement actual validation logic if needed

var cfg RunJavascriptConfig

if err := json.Unmarshal([]byte(configJSON), &cfg); err != nil {

return errors.New("invalid JSON for run_javascript config: " + err.Error())

}

if strings.TrimSpace(cfg.Script) == "" {

return errors.New("run_javascript config must contain a non-empty 'script' field")

}

Copilot · 2025-11-10T15:32:06Z

frontend/src/lib/components/actions/ActionFilterForm.svelte

+						class="text-red-500 hover:text-red-400 text-sm"
+						on:click={() => removeFilter(index)}
+						title="Remove filter"
+						aria-label="Remove filter {index + 1}"


The icon-only button should include 'aria-label' without the {index + 1} template syntax inside the attribute value. This creates confusing output. Change to: aria-label="Remove filter" and let the context determine which filter is being removed, or properly interpolate: aria-label='Remove filter {index + 1}' (note single quotes for proper Svelte interpolation).

Suggested change

aria-label="Remove filter {index + 1}"

aria-label='Remove filter {index + 1}'

Copilot · 2025-11-10T15:32:07Z

backend/src/actions/modules/action_run_javascript.go

+	})
+	vm.Set("console", consoleObj)
+
+	// Clone context to avoid modifying the original


The comment says 'Clone context' but the code is actually marshaling (serializing) the context to JSON, not cloning it. Update comment to: 'Serialize context to JSON for VM execution' to accurately describe the operation.

Suggested change

// Clone context to avoid modifying the original

// Serialize context to JSON for VM execution

Copilot · 2025-11-10T15:32:07Z

backend/src/actions/handler.go

+// UpdateActionPriorityRequest represents the request to update action priority
+// Priority is 1-based (starts from 1, not 0)


The comment correctly explains that priority is 1-based, but it would be helpful to also document the upper bound and what happens when the priority exceeds the number of actions in the execution point group. Add a comment explaining that priority values are constrained to the valid range [1, N] where N is the count of actions in the same execution point.

Suggested change

// UpdateActionPriorityRequest represents the request to update action priority

// Priority is 1-based (starts from 1, not 0)

// UpdateActionPriorityRequest represents the request to update action priority.

// Priority is 1-based (starts from 1, not 0).

// Priority values are constrained to the valid range [1, N], where N is the count of actions in the same execution point group.

// If the priority exceeds N, the request will be rejected with an error.

Copilot · 2025-11-10T15:32:07Z

frontend/src/lib/components/actions/ActionList.svelte

+							<div
+								bind:this={actionElements[action.id]}
+								role="button"
+								tabindex="0"
+								draggable="true"
+								on:dragstart={() => handleDragStart(action, idx)}
+								on:dragover={handleDragOver}
+								on:drop={(e) => handleDrop(e, action, idx)}
+								on:dragend={handleDragEnd}
+								on:keydown={(e) => {
+									if (e.key === 'Enter' || e.key === ' ') {
+										e.preventDefault();
+									}
+								}}


The keydown handler prevents default behavior for Enter and Space keys but doesn't actually perform any action. This breaks keyboard accessibility for users who can't use drag-and-drop. Implement keyboard-based reordering (e.g., using arrow keys or providing alternative action buttons) to ensure keyboard users can reorder actions.

Copilot · 2025-11-10T15:32:08Z

backend/src/actions/service.go

+	// Reorder priorities - only update affected actions in the same execution point
+	if oldPriority < newPriority {
+		// Moving down: shift actions up (decrease priority)
+		for i := range sameExecutionPointActions {
+			if sameExecutionPointActions[i].ID == actionID {
+				sameExecutionPointActions[i].Priority = newPriority
+				affectedActions = append(affectedActions, &sameExecutionPointActions[i])
+				affectedCount++
+			} else if sameExecutionPointActions[i].Priority > oldPriority && sameExecutionPointActions[i].Priority <= newPriority {
+				sameExecutionPointActions[i].Priority--
+				affectedActions = append(affectedActions, &sameExecutionPointActions[i])
+				affectedCount++
+			}
+		}
+	} else {


The priority reordering logic modifies a slice element directly and then takes its address to append to affectedActions. This creates a pointer to a loop variable which could lead to subtle bugs. Consider refactoring to work with pointers throughout or create a separate variable for the modified action before appending.

Copilot · 2025-11-10T15:32:08Z

docs/Actions_Documentation.md

+#### JavaScript Limitations:
+- **Timeout:** 5 seconds maximum
+- **No async/await** - Synchronous code only
+- **No external libraries** - Standard JavaScript only (ES5)


The documentation states 'Standard JavaScript only (ES5)' but the implementation uses goja which supports ES5.1+ and many ES6 features. Update the documentation to accurately reflect the supported JavaScript version to avoid confusing users about what language features they can use.

Suggested change

- **No external libraries** - Standard JavaScript only (ES5)

- **No external libraries** - Standard JavaScript (ES5.1 and many ES6 features supported, e.g. `let`, `const`, arrow functions, etc.)

yogasw and others added 24 commits November 3, 2025 03:02

chore: update CHANGELOG.md for v2.5.3

4b508e6

Merge pull request #144 from yogasw/changelog/update-2.5.3

48b58c1

Update CHANGELOG.md for v2.5.3

add action feature

712cc23

update header action

988f251

execute request to echo service

057c8f6

add request id to improve logs

c3dd11d

refactor: replace default logger with custom logger and add recovery …

3ae2543

…middleware

improve code

933b44a

improve code

14574a1

restructure folder action

f95e949

improve list action

c27edd7

improve header create action

70bb2a3

improve header and list actions

bf825c5

improve structure code

540f9d7

revamp action form

e573aa0

improve replace text validation

109e81c

update priorty action

ccd9cc6

add javascript action

cf0aaa2

remove sample code

47fa1d7

version 2.6.0

54884d2

add docs action

d26a397

Merge pull request #145 from yogasw/features/actions

14d69c1

Features/actions

update pipelines

a1465a8

Merge pull request #146 from yogasw/fix-pipelines

8a6de4b

update pipelines

yogasw requested a review from Copilot November 10, 2025 15:27

yogasw temporarily deployed to main - beo-echo PR #147 November 10, 2025 15:27 — with Render Destroyed

github-actions bot merged commit b526494 into release Nov 10, 2025
10 checks passed

Copilot AI reviewed Nov 10, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2.6.0#147

2.6.0#147
github-actions[bot] merged 24 commits intoreleasefrom
main

yogasw commented Nov 10, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Copilot AI Nov 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

-	// TODO : Implement actual validation logic if needed
+	var cfg RunJavascriptConfig
+	if err := json.Unmarshal([]byte(configJSON), &cfg); err != nil {
+		return errors.New("invalid JSON for run_javascript config: " + err.Error())
+	}
+	if strings.TrimSpace(cfg.Script) == "" {
+		return errors.New("run_javascript config must contain a non-empty 'script' field")
+	}

	aria-label="Remove filter {index + 1}"
	aria-label='Remove filter {index + 1}'

	// Clone context to avoid modifying the original
	// Serialize context to JSON for VM execution

		// UpdateActionPriorityRequest represents the request to update action priority
		// Priority is 1-based (starts from 1, not 0)

-// UpdateActionPriorityRequest represents the request to update action priority
-// Priority is 1-based (starts from 1, not 0)
+// UpdateActionPriorityRequest represents the request to update action priority.
+// Priority is 1-based (starts from 1, not 0).
+// Priority values are constrained to the valid range [1, N], where N is the count of actions in the same execution point group.
+// If the priority exceeds N, the request will be rejected with an error.

	- No external libraries - Standard JavaScript only (ES5)
	- No external libraries - Standard JavaScript (ES5.1 and many ES6 features supported, e.g. `let`, `const`, arrow functions, etc.)

Conversation

yogasw commented Nov 10, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Reviewed Changes

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants