Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yoonc01
reviewed
Feb 10, 2025
Owner
There was a problem hiding this comment.
modal component에서
const [isMobile, setIsMobile] = useState(window.innerWidth < 768);
로 수정하고 16번째에서 24번째 줄을 이렇게 바꾸는 것은 어떤가요???
useEffect(() => {
const handleResize = () => setIsMobile(window.innerWidth < 768);
window.addEventListener('resize', handleResize);
return () => window.removeEventListener('resize', handleResize);
}, []);
Comment on lines
-28
to
+29
| <div className="fixed flex flex-col top-0 left-0 size-full bg-midnightBlack"> | ||
| // z-[9999] : 모달창이 열렸을 때 리스트 페이지에 있는 아이돌 이미지 보더가 같이 보이는 현상 해결을 위해 작성 | ||
| <div className="fixed flex flex-col top-0 left-0 size-full bg-midnightBlack z-[9999]"> |
Owner
There was a problem hiding this comment.
여기서 idolCard에 있는 border의 z인덱스를 지우는 것은 어떤가용 그게 필요가 없어 보이는 거 같아서요!
yoonc01
approved these changes
Feb 10, 2025
Owner
yoonc01
left a comment
There was a problem hiding this comment.
commit 단위를 조금 더 세분화했으면 읽는데 더 편했을 거 같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ Issue Number
#146
📝 요약(Summary)
🛠️ PR 유형
어떤 변경 사항이 있나요?
📸스크린샷 (선택)
수정 부분이 너무 많아 사진으로 다 담기 어려울 거 같아 vercel에서 제공하는 PR 사이트 참고해 주시면 감사하겠습니다!! :)