Change valid URL check regular expression to validator library

yorkie-team · Sep 5, 2024 · 4d3b2e4 · 4d3b2e4
1 parent 485d3af
commit 4d3b2e4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 3 deletions.
diff --git a/frontend/package-lock.json b/frontend/package-lock.json
diff --git a/frontend/package.json b/frontend/package.json
@@ -87,6 +87,7 @@
 		"@types/react-dom": "^18.2.17",
 		"@types/react-infinite-scroller": "^1.2.5",
 		"@types/react-scroll-sync": "^0.9.0",
+		"@types/validator": "^13.12.1",
 		"@typescript-eslint/eslint-plugin": "^6.14.0",
 		"@typescript-eslint/parser": "^6.14.0",
 		"@vitejs/plugin-react": "^4.2.1",

diff --git a/frontend/src/utils/urlHyperlinkInserter.ts b/frontend/src/utils/urlHyperlinkInserter.ts
@@ -1,10 +1,9 @@
 import { EditorView } from "codemirror";
+import validator from "validator";
 import { CodePairDocType } from "../store/editorSlice";
 
 const isValidUrl = (url: string) => {
-	// eslint-disable-next-line no-useless-escape
-	const urlRegex = /^(https?|ftp):\/\/(-\.)?([^\s\/?\.#-]+\.?)+(\/[^\s]*)?$/i;
-	return urlRegex.test(url);
+	return validator.isURL(url);
 };
 
 const insertLinkToEditor = (url: string, view: EditorView, doc: CodePairDocType) => {