Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure correct representation of logged-in users in shared document view #333

Conversation

choidabom
Copy link
Contributor

@choidabom choidabom commented Sep 4, 2024

What this PR does / why we need it?

This PR fixes the problem where users are erroneously identified as anonymous in shared documents despite being logged in. The aim is to make sure the system accurately recognizes and displays the user's login status when they access shared documents.

Any background context you want to provide?

Users have encountered a situation where their identity is shown as anonymous when they open shared documents. This issue seems to originate from problems relating to authentication or session management, which can potentially confuse users who expect to see their logged-in status.

What are the relevant tickets?

Fixes #148

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Summary by CodeRabbit

  • New Features
    • Enhanced document sharing functionality by personalizing user nicknames instead of using a generic label.
    • Users will now see their own nickname when sharing documents, improving the overall user experience.

@choidabom choidabom self-assigned this Sep 4, 2024
Copy link
Contributor

coderabbitai bot commented Sep 4, 2024

Walkthrough

The changes in the DocumentShareIndex component improve user role handling and document sharing functionality by integrating the current user's nickname from the Redux store. This replaces the previous hardcoded "Anonymous" label, allowing for a personalized user experience when accessing shared documents.

Changes

File Path Change Summary
frontend/src/pages/workspace/document/share/Index.tsx Introduced userStore using useSelector(selectUser) to retrieve current user data and dynamically set user nickname.

Assessment against linked issues

Objective Addressed Explanation
Properly display logged-in user instead of anonymous ( #148 )

🐰 In the meadow, where bunnies play,
A nickname brightens up the day!
No more "Anonymous" in sight,
Each user shines, a joyful light!
Hopping 'round with glee and cheer,
Sharing documents, friends are near! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 3682417 and 143f76d.

Files selected for processing (1)
  • frontend/src/pages/workspace/document/share/Index.tsx (1 hunks)
Additional comments not posted (5)
frontend/src/pages/workspace/document/share/Index.tsx (5)

2-2: LGTM!

The code changes are approved.


3-3: LGTM!

The code changes are approved.


9-9: LGTM!

The code changes are approved.


15-15: LGTM!

The code changes are approved.


18-21: LGTM!

The code changes are approved.

Copy link
Member

@devleejb devleejb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@devleejb devleejb merged commit 0485293 into yorkie-team:main Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Anonymous access when accessing shared documents despite being logged in
2 participants