Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gallery and show icon #137

Merged
merged 59 commits into from
Jul 13, 2024
Merged

Update gallery and show icon #137

merged 59 commits into from
Jul 13, 2024

Conversation

vitran12
Copy link
Contributor

@vitran12 vitran12 commented Jul 13, 2024

What this PR does / why we need it:

  • Update gallery and show icon
    Special notes for your reviewer:

Which issue(s) this PR fixes:

Fixes #

Checklist:

  • Added relevant tests or not required
  • Didn't break anything

Summary by CodeRabbit

  • New Features

    • Added Button component for "Getting Started" with a link to the documentation.
    • Added Checkbox component with label.
  • Improvements

    • Enhanced Storybook with console logging for easier debugging.
    • Updated icon generation to dynamically inherit stroke attributes.
    • Refined Icon component to improve prop handling and display logic.
  • Bug Fixes

    • Corrected the Accordion component removal and cleaned up associated code.
    • Fixed minor syntax issues in several components.
  • Dependencies

    • Added @storybook/addon-console dependency.
    • Bumped package version from "0.5.28" to "0.5.29".

@vitran12 vitran12 self-assigned this Jul 13, 2024
Copy link

coderabbitai bot commented Jul 13, 2024

Walkthrough

The recent changes encompass a variety of updates including adding a console addon to Storybook, refining the icon generation script, updating the package.json version, and altering components in the page.tsx and Accordion.tsx files. Additionally, there were substantial modifications to the icon stories and components to enhance their functionality and behavior.

Changes

File(s) Summary
.storybook/preview.tsx Added console logging addon to Storybook configuration.
generateIcons.js Updated to modify SVG icons by removing and re-adding the stroke attribute.
package.json Incremented project version and added new dependency @storybook/addon-console.
src/app/page.tsx Replaced Accordion with a Button for "Getting Started" and added a Checkbox component.
src/components/ui/accordion/Accordion.tsx Added a semicolon at the end of the 'use client' statement.
src/components/ui/icon/Icon.mdx Removed source attribute with format: true from the <Canvas> component.
src/components/ui/icon/Icon.stories.tsx Refactored icon story components for better organization and behavior.
src/components/ui/icon/Icon.tsx Reordered props within the StyledIcon component.

Poem

In the code where changes bloom,
Icons dance without a flume,
Checkboxes and buttons bright,
Storybook logs in sight!
Version numbers rise anew,
With tweaks and fixes, here for you.
A coderabbit's joy in the code,
Along the paths, new features flowed!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between befcbcc and d3af312.

Files ignored due to path filters (292)
  • package-lock.json is excluded by !**/package-lock.json
  • src/components/ui/icons/Vector.svg is excluded by !**/*.svg
  • src/components/ui/icons/account.svg is excluded by !**/*.svg
  • src/components/ui/icons/add-member.svg is excluded by !**/*.svg
  • src/components/ui/icons/albums.svg is excluded by !**/*.svg
  • src/components/ui/icons/albums2.svg is excluded by !**/*.svg
  • src/components/ui/icons/alert-danger.svg is excluded by !**/*.svg
  • src/components/ui/icons/alert-info.svg is excluded by !**/*.svg
  • src/components/ui/icons/alert-success.svg is excluded by !**/*.svg
  • src/components/ui/icons/alert-warning.svg is excluded by !**/*.svg
  • src/components/ui/icons/alert.svg is excluded by !**/*.svg
  • src/components/ui/icons/analytics.svg is excluded by !**/*.svg
  • src/components/ui/icons/anchor.svg is excluded by !**/*.svg
  • src/components/ui/icons/apple.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-back.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-back2.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-circle-right.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-down-circle.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-down.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-first.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-last.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-left-circle.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-left-down.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-left-right.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-left-up.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-left.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-product.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-right-circle.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-right-dow.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-right-up.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-right.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-up-circle.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-up-down.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow-up.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow.svg is excluded by !**/*.svg
  • src/components/ui/icons/arrow2.svg is excluded by !**/*.svg
  • src/components/ui/icons/artist.svg is excluded by !**/*.svg
  • src/components/ui/icons/back-home.svg is excluded by !**/*.svg
  • src/components/ui/icons/back.svg is excluded by !**/*.svg
  • src/components/ui/icons/backward.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-A.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-B.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-C.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-D.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-E.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-F.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-G.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-H.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-I.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-J.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-K.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-L.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-M.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-N.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-O.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-P.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-Q.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-R.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-S.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-T.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-U.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-V.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-W.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-X.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-Y.svg is excluded by !**/*.svg
  • src/components/ui/icons/badge-Z.svg is excluded by !**/*.svg
  • src/components/ui/icons/bank-note.svg is excluded by !**/*.svg
  • src/components/ui/icons/bank.svg is excluded by !**/*.svg
  • src/components/ui/icons/barrier.svg is excluded by !**/*.svg
  • src/components/ui/icons/beautiful.svg is excluded by !**/*.svg
  • src/components/ui/icons/book.svg is excluded by !**/*.svg
  • src/components/ui/icons/branch.svg is excluded by !**/*.svg
  • src/components/ui/icons/bulb.svg is excluded by !**/*.svg
  • src/components/ui/icons/camera.svg is excluded by !**/*.svg
  • src/components/ui/icons/canvas.svg is excluded by !**/*.svg
  • src/components/ui/icons/chart.svg is excluded by !**/*.svg
  • src/components/ui/icons/chat.svg is excluded by !**/*.svg
  • src/components/ui/icons/check-circle.svg is excluded by !**/*.svg
  • src/components/ui/icons/check-mark.svg is excluded by !**/*.svg
  • src/components/ui/icons/check.svg is excluded by !**/*.svg
  • src/components/ui/icons/checkbox-fill-circle.svg is excluded by !**/*.svg
  • src/components/ui/icons/checkbox-fill-square.svg is excluded by !**/*.svg
  • src/components/ui/icons/chev-down.svg is excluded by !**/*.svg
  • src/components/ui/icons/chev-left.svg is excluded by !**/*.svg
  • src/components/ui/icons/chev-right.svg is excluded by !**/*.svg
  • src/components/ui/icons/chev-up.svg is excluded by !**/*.svg
  • src/components/ui/icons/circle-close.svg is excluded by !**/*.svg
  • src/components/ui/icons/circle-filled.svg is excluded by !**/*.svg
  • src/components/ui/icons/circle-quetion-mark.svg is excluded by !**/*.svg
  • src/components/ui/icons/circle.svg is excluded by !**/*.svg
  • src/components/ui/icons/clock.svg is excluded by !**/*.svg
  • src/components/ui/icons/close-small.svg is excluded by !**/*.svg
  • src/components/ui/icons/close.svg is excluded by !**/*.svg
  • src/components/ui/icons/cloud-border.svg is excluded by !**/*.svg
  • src/components/ui/icons/cloud-orange.svg is excluded by !**/*.svg
  • src/components/ui/icons/cloud.svg is excluded by !**/*.svg
  • src/components/ui/icons/code-snippet.svg is excluded by !**/*.svg
  • src/components/ui/icons/coin.svg is excluded by !**/*.svg
  • src/components/ui/icons/coins.svg is excluded by !**/*.svg
  • src/components/ui/icons/collaborate-cursor.svg is excluded by !**/*.svg
  • src/components/ui/icons/collaborate-editing.svg is excluded by !**/*.svg
  • src/components/ui/icons/collaborate-profile.svg is excluded by !**/*.svg
  • src/components/ui/icons/collaborate-selection.svg is excluded by !**/*.svg
  • src/components/ui/icons/color-picked.svg is excluded by !**/*.svg
  • src/components/ui/icons/color-picker.svg is excluded by !**/*.svg
  • src/components/ui/icons/comment.svg is excluded by !**/*.svg
  • src/components/ui/icons/community-help.svg is excluded by !**/*.svg
  • src/components/ui/icons/community_help.svg is excluded by !**/*.svg
  • src/components/ui/icons/confirm.svg is excluded by !**/*.svg
  • src/components/ui/icons/container.svg is excluded by !**/*.svg
  • src/components/ui/icons/cookie.svg is excluded by !**/*.svg
  • src/components/ui/icons/copy.svg is excluded by !**/*.svg
  • src/components/ui/icons/credit-card-2.svg is excluded by !**/*.svg
  • src/components/ui/icons/credit-card.svg is excluded by !**/*.svg
  • src/components/ui/icons/cursor.svg is excluded by !**/*.svg
  • src/components/ui/icons/dark-mode.svg is excluded by !**/*.svg
  • src/components/ui/icons/dashboard-user-green.svg is excluded by !**/*.svg
  • src/components/ui/icons/dashboard-user-purple.svg is excluded by !**/*.svg
  • src/components/ui/icons/dashboard-user-red.svg is excluded by !**/*.svg
  • src/components/ui/icons/dashboard-user-yellow.svg is excluded by !**/*.svg
  • src/components/ui/icons/date.svg is excluded by !**/*.svg
  • src/components/ui/icons/delete.svg is excluded by !**/*.svg
  • src/components/ui/icons/delivery.svg is excluded by !**/*.svg
  • src/components/ui/icons/diamond.svg is excluded by !**/*.svg
  • src/components/ui/icons/discord.svg is excluded by !**/*.svg
  • src/components/ui/icons/document.svg is excluded by !**/*.svg
  • src/components/ui/icons/dot.svg is excluded by !**/*.svg
  • src/components/ui/icons/download.svg is excluded by !**/*.svg
  • src/components/ui/icons/drag.svg is excluded by !**/*.svg
  • src/components/ui/icons/dribbble.svg is excluded by !**/*.svg
  • src/components/ui/icons/edit.svg is excluded by !**/*.svg
  • src/components/ui/icons/error.svg is excluded by !**/*.svg
  • src/components/ui/icons/error404.svg is excluded by !**/*.svg
  • src/components/ui/icons/error500.svg is excluded by !**/*.svg
  • src/components/ui/icons/expand.svg is excluded by !**/*.svg
  • src/components/ui/icons/eye-off.svg is excluded by !**/*.svg
  • src/components/ui/icons/eye.svg is excluded by !**/*.svg
  • src/components/ui/icons/facebook-color.svg is excluded by !**/*.svg
  • src/components/ui/icons/facebook.svg is excluded by !**/*.svg
  • src/components/ui/icons/file.svg is excluded by !**/*.svg
  • src/components/ui/icons/filter.svg is excluded by !**/*.svg
  • src/components/ui/icons/folder-closed.svg is excluded by !**/*.svg
  • src/components/ui/icons/folder-open.svg is excluded by !**/*.svg
  • src/components/ui/icons/folder-shared.svg is excluded by !**/*.svg
  • src/components/ui/icons/folder.svg is excluded by !**/*.svg
  • src/components/ui/icons/fork.svg is excluded by !**/*.svg
  • src/components/ui/icons/forward.svg is excluded by !**/*.svg
  • src/components/ui/icons/github.svg is excluded by !**/*.svg
  • src/components/ui/icons/gnb-menu.svg is excluded by !**/*.svg
  • src/components/ui/icons/google.svg is excluded by !**/*.svg
  • src/components/ui/icons/hammer-law.svg is excluded by !**/*.svg
  • src/components/ui/icons/hammer.svg is excluded by !**/*.svg
  • src/components/ui/icons/hand-medical.svg is excluded by !**/*.svg
  • src/components/ui/icons/hand-open.svg is excluded by !**/*.svg
  • src/components/ui/icons/hand.svg is excluded by !**/*.svg
  • src/components/ui/icons/heart-rate.svg is excluded by !**/*.svg
  • src/components/ui/icons/heart.svg is excluded by !**/*.svg
  • src/components/ui/icons/help.svg is excluded by !**/*.svg
  • src/components/ui/icons/home.svg is excluded by !**/*.svg
  • src/components/ui/icons/hourglass.svg is excluded by !**/*.svg
  • src/components/ui/icons/icon_checkbox_fill_circle.svg is excluded by !**/*.svg
  • src/components/ui/icons/iconnect.svg is excluded by !**/*.svg
  • src/components/ui/icons/image.svg is excluded by !**/*.svg
  • src/components/ui/icons/info.svg is excluded by !**/*.svg
  • src/components/ui/icons/input.svg is excluded by !**/*.svg
  • src/components/ui/icons/instagram.svg is excluded by !**/*.svg
  • src/components/ui/icons/invest.svg is excluded by !**/*.svg
  • src/components/ui/icons/invisible.svg is excluded by !**/*.svg
  • src/components/ui/icons/job.svg is excluded by !**/*.svg
  • src/components/ui/icons/key.svg is excluded by !**/*.svg
  • src/components/ui/icons/keynote.svg is excluded by !**/*.svg
  • src/components/ui/icons/label.svg is excluded by !**/*.svg
  • src/components/ui/icons/language.svg is excluded by !**/*.svg
  • src/components/ui/icons/law.svg is excluded by !**/*.svg
  • src/components/ui/icons/light-dark.svg is excluded by !**/*.svg
  • src/components/ui/icons/light-mode.svg is excluded by !**/*.svg
  • src/components/ui/icons/lightbulb.svg is excluded by !**/*.svg
  • src/components/ui/icons/lightning.svg is excluded by !**/*.svg
  • src/components/ui/icons/line.svg is excluded by !**/*.svg
  • src/components/ui/icons/link.svg is excluded by !**/*.svg
  • src/components/ui/icons/linkedIn-color.svg is excluded by !**/*.svg
  • src/components/ui/icons/linkedIn.svg is excluded by !**/*.svg
  • src/components/ui/icons/list.svg is excluded by !**/*.svg
  • src/components/ui/icons/loading.svg is excluded by !**/*.svg
  • src/components/ui/icons/location.svg is excluded by !**/*.svg
  • src/components/ui/icons/lock-small.svg is excluded by !**/*.svg
  • src/components/ui/icons/lock.svg is excluded by !**/*.svg
  • src/components/ui/icons/logo-3d-2.svg is excluded by !**/*.svg
  • src/components/ui/icons/logo-3d-side.svg is excluded by !**/*.svg
  • src/components/ui/icons/logo-3d.svg is excluded by !**/*.svg
  • src/components/ui/icons/logo-footer.svg is excluded by !**/*.svg
  • src/components/ui/icons/logo-gnb.svg is excluded by !**/*.svg
  • src/components/ui/icons/logo-horizontal-l.svg is excluded by !**/*.svg
  • src/components/ui/icons/logo-horizontal-s-gray.svg is excluded by !**/*.svg
  • src/components/ui/icons/logo-horizontal-s.svg is excluded by !**/*.svg
  • src/components/ui/icons/logo-horizontal-xs.svg is excluded by !**/*.svg
  • src/components/ui/icons/logo-no-text.svg is excluded by !**/*.svg
  • src/components/ui/icons/logo-text.svg is excluded by !**/*.svg
  • src/components/ui/icons/logo.svg is excluded by !**/*.svg
  • src/components/ui/icons/logout.svg is excluded by !**/*.svg
  • src/components/ui/icons/mail.svg is excluded by !**/*.svg
  • src/components/ui/icons/material.svg is excluded by !**/*.svg
  • src/components/ui/icons/medal.svg is excluded by !**/*.svg
  • src/components/ui/icons/medical.svg is excluded by !**/*.svg
  • src/components/ui/icons/member-email.svg is excluded by !**/*.svg
  • src/components/ui/icons/menu.svg is excluded by !**/*.svg
  • src/components/ui/icons/message-smile.svg is excluded by !**/*.svg
  • src/components/ui/icons/message-square.svg is excluded by !**/*.svg
  • src/components/ui/icons/message.svg is excluded by !**/*.svg
  • src/components/ui/icons/microphone.svg is excluded by !**/*.svg
  • src/components/ui/icons/minimize.svg is excluded by !**/*.svg
  • src/components/ui/icons/minus-circle.svg is excluded by !**/*.svg
  • src/components/ui/icons/minus.svg is excluded by !**/*.svg
  • src/components/ui/icons/mircrophone-mute.svg is excluded by !**/*.svg
  • src/components/ui/icons/more-large.svg is excluded by !**/*.svg
  • src/components/ui/icons/more.svg is excluded by !**/*.svg
  • src/components/ui/icons/mute.svg is excluded by !**/*.svg
  • src/components/ui/icons/naver.svg is excluded by !**/*.svg
  • src/components/ui/icons/neutral.svg is excluded by !**/*.svg
  • src/components/ui/icons/next.svg is excluded by !**/*.svg
  • src/components/ui/icons/notification.svg is excluded by !**/*.svg
  • src/components/ui/icons/open-selector.svg is excluded by !**/*.svg
  • src/components/ui/icons/package.svg is excluded by !**/*.svg
  • src/components/ui/icons/packaging.svg is excluded by !**/*.svg
  • src/components/ui/icons/paperplane.svg is excluded by !**/*.svg
  • src/components/ui/icons/pause-circle.svg is excluded by !**/*.svg
  • src/components/ui/icons/pause.svg is excluded by !**/*.svg
  • src/components/ui/icons/pen.svg is excluded by !**/*.svg
  • src/components/ui/icons/pie-chart.svg is excluded by !**/*.svg
  • src/components/ui/icons/piggy-bank-coin.svg is excluded by !**/*.svg
  • src/components/ui/icons/piggy-bank.svg is excluded by !**/*.svg
  • src/components/ui/icons/pin.svg is excluded by !**/*.svg
  • src/components/ui/icons/placeholder.svg is excluded by !**/*.svg
  • src/components/ui/icons/play-circle.svg is excluded by !**/*.svg
  • src/components/ui/icons/play.svg is excluded by !**/*.svg
  • src/components/ui/icons/playlist.svg is excluded by !**/*.svg
  • src/components/ui/icons/plus-circle.svg is excluded by !**/*.svg
  • src/components/ui/icons/plus.svg is excluded by !**/*.svg
  • src/components/ui/icons/pop-remove.svg is excluded by !**/*.svg
  • src/components/ui/icons/previous.svg is excluded by !**/*.svg
  • src/components/ui/icons/print.svg is excluded by !**/*.svg
  • src/components/ui/icons/radio.svg is excluded by !**/*.svg
  • src/components/ui/icons/recipe.svg is excluded by !**/*.svg
  • src/components/ui/icons/recorder.svg is excluded by !**/*.svg
  • src/components/ui/icons/refresh.svg is excluded by !**/*.svg
  • src/components/ui/icons/repeat.svg is excluded by !**/*.svg
  • src/components/ui/icons/report.svg is excluded by !**/*.svg
  • src/components/ui/icons/reset.svg is excluded by !**/*.svg
  • src/components/ui/icons/rocket.svg is excluded by !**/*.svg
  • src/components/ui/icons/route.svg is excluded by !**/*.svg
  • src/components/ui/icons/rules.svg is excluded by !**/*.svg
  • src/components/ui/icons/sad.svg is excluded by !**/*.svg
  • src/components/ui/icons/safety.svg is excluded by !**/*.svg
  • src/components/ui/icons/scenario.svg is excluded by !**/*.svg
  • src/components/ui/icons/search.svg is excluded by !**/*.svg
  • src/components/ui/icons/service-main-users-alone.svg is excluded by !**/*.svg
  • src/components/ui/icons/service-mainusers-group.svg is excluded by !**/*.svg
  • src/components/ui/icons/service.svg is excluded by !**/*.svg
  • src/components/ui/icons/setting.svg is excluded by !**/*.svg
  • src/components/ui/icons/settings.svg is excluded by !**/*.svg
  • src/components/ui/icons/shop.svg is excluded by !**/*.svg
  • src/components/ui/icons/shopping-bag.svg is excluded by !**/*.svg
  • src/components/ui/icons/shopping-basket.svg is excluded by !**/*.svg
  • src/components/ui/icons/short-cut.svg is excluded by !**/*.svg
  • src/components/ui/icons/shrink.svg is excluded by !**/*.svg
  • src/components/ui/icons/shuffle.svg is excluded by !**/*.svg
  • src/components/ui/icons/slack.svg is excluded by !**/*.svg
  • src/components/ui/icons/smartphone.svg is excluded by !**/*.svg
  • src/components/ui/icons/smile.svg is excluded by !**/*.svg
  • src/components/ui/icons/songs.svg is excluded by !**/*.svg
  • src/components/ui/icons/square-check.svg is excluded by !**/*.svg
  • src/components/ui/icons/square-exclamation.svg is excluded by !**/*.svg
  • src/components/ui/icons/square.svg is excluded by !**/*.svg
  • src/components/ui/icons/stable-monitoring.svg is excluded by !**/*.svg
  • src/components/ui/icons/stable-server.svg is excluded by !**/*.svg
  • src/components/ui/icons/stable-sharing.svg is excluded by !**/*.svg
  • src/components/ui/icons/star-full.svg is excluded by !**/*.svg
  • src/components/ui/icons/star.svg is excluded by !**/*.svg
  • src/components/ui/icons/stars.svg is excluded by !**/*.svg
  • src/components/ui/icons/stop-circle.svg is excluded by !**/*.svg
  • src/components/ui/icons/stop.svg is excluded by !**/*.svg
  • src/components/ui/icons/sum.svg is excluded by !**/*.svg
  • src/components/ui/icons/system-user-green.svg is excluded by !**/*.svg
  • src/components/ui/icons/system-user-pink.svg is excluded by !**/*.svg
  • src/components/ui/icons/system-user-purple.svg is excluded by !**/*.svg
  • src/components/ui/icons/team.svg is excluded by !**/*.svg
  • src/components/ui/icons/telegram.svg is excluded by !**/*.svg
  • src/components/ui/icons/thumbs.svg is excluded by !**/*.svg
  • src/components/ui/icons/timer.svg is excluded by !**/*.svg
  • src/components/ui/icons/token.svg is excluded by !**/*.svg
  • src/components/ui/icons/tool.svg is excluded by !**/*.svg
  • src/components/ui/icons/top-button.svg is excluded by !**/*.svg
Files selected for processing (8)
  • .storybook/preview.tsx (1 hunks)
  • generateIcons.js (1 hunks)
  • package.json (2 hunks)
  • src/app/page.tsx (3 hunks)
  • src/components/ui/accordion/Accordion.tsx (1 hunks)
  • src/components/ui/icon/Icon.mdx (1 hunks)
  • src/components/ui/icon/Icon.stories.tsx (3 hunks)
  • src/components/ui/icon/Icon.tsx (1 hunks)
Files skipped from review due to trivial changes (3)
  • package.json
  • src/components/ui/accordion/Accordion.tsx
  • src/components/ui/icon/Icon.mdx
Additional comments not posted (9)
src/components/ui/icon/Icon.tsx (1)

14-14: LGTM!

The reordering of props in the StyledIcon component improves code readability and maintainability without affecting functionality.

.storybook/preview.tsx (1)

4-5: Enhanced logging capabilities added.

The imports and integration of withConsole from @storybook/addon-console enhance the logging capabilities in Storybook, which is beneficial for debugging and monitoring.

generateIcons.js (1)

32-43: Consistent styling for SVG icons.

The changes remove the stroke attribute from SVG elements and replace it with stroke="inherit", ensuring consistent styling.

src/components/ui/icon/Icon.stories.tsx (5)

6-6: Improved modularity and maintainability.

The refactoring of the Gallery component into IconList and IconComponentWrapper improves the modularity and maintainability of the code.


52-60: New types and interfaces added.

The addition of handleClickCopy type and IconComponentWrapperProps interface enhances type safety and code clarity.


62-103: Dynamic stroke color logic implemented.

The implementation of dynamic stroke color logic based on SVG fill presence enhances the visual consistency of the icons.


105-143: New component IconComponentWrapper added.

The addition of IconComponentWrapper improves the modularity and reusability of the code.


145-147: Refactored Gallery component.

The refactoring of the Gallery component into IconList and IconComponentWrapper improves the code structure and readability.

src/app/page.tsx (1)

31-42: LGTM!

The Button component is correctly implemented with the necessary props and links to /docs/getting-started.

@vitran12 vitran12 merged commit e8b0a18 into main Jul 13, 2024
2 checks passed
@vitran12 vitran12 deleted the alice/new-update branch July 13, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant