[#32] Avatar component #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To update and custom avatar styles
To fix error with es5
vitran12
reviewed
Jan 11, 2024
src/components/ui/avatar/Avatar.tsx
Outdated
| import { forwardRef } from 'react'; | ||
| import { avatar, type AvatarVariantProps } from '@/styled/recipes'; | ||
|
|
||
| export interface AvatarProps extends ArkAvatarProps, AvatarVariantProps { |
There was a problem hiding this comment.
You should new file name: types.ts and move interface and type into it.
src/components/ui/avatar/Avatar.tsx
Outdated
| import { avatar, type AvatarVariantProps } from '@/styled/recipes'; | ||
|
|
||
| export interface AvatarProps extends ArkAvatarProps, AvatarVariantProps { | ||
| name?: string; |
There was a problem hiding this comment.
You should note comment for name property. example:
/** name is plalala */
| src?: string; | ||
| } | ||
|
|
||
| export const Avatar = forwardRef<HTMLDivElement, AvatarProps>((props, ref) => { |
There was a problem hiding this comment.
You should write a description for the function and param of us. Example:
/**
* @description This function render style for Avatar.
*/
src/components/ui/avatar/Avatar.tsx
Outdated
| </svg> | ||
| ); | ||
|
|
||
| const getInitials = (name = '') => |
There was a problem hiding this comment.
What is a util?
If this is a util, you can move it into util file
src/components/ui/avatar/Avatar.tsx
Outdated
|
|
||
| Avatar.displayName = 'Avatar'; | ||
|
|
||
| const UserIcon = () => ( |
There was a problem hiding this comment.
You should we will create 1 file manage Icons.
Example
Import {UserIcon} from 'icons'.
Refactor file structure
To divide icons into seperate folder
I updated. Please help me check it before I update others. Thanks a lot @vitran12 |
vitran12
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Special notes for your reviewer:
Which issue(s) this PR fixes:
Fixes #32
Screenshoots:
Checklist: