Skip to content

Fix app-language handling in appearance and download messages - #311

Merged
yukuku merged 1 commit into
developfrom
codex/fix-app-language-strings
Oct 6, 2026
Merged

yukuku merged 1 commit into
developfrom
codex/fix-app-language-strings

Conversation

@yukuku

@yukuku yukuku commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Implementation

With Indonesian selected in the app and English on the device, the appearance panel showed “Download more fonts…” and “Color theme” in English. The font option now follows the app language, and the color theme label has the Indonesian translation “Tema warna”.

The same language-context issue is fixed in Bible download failure dialogs and completion toasts, version-list update messages, and the download service's temporary-file rename error.

Technical details

  • Resolve the font download option with Compose stringResource and pass the localized label into the font option builder.
  • Add the missing Indonesian color theme resource.
  • Route background download and version-list strings through the existing Localized helper, which refreshes its cached resources when the preferred locale changes.
  • Build those resources through ConfigurationWrapper.localizedContext so string lookup copies the configuration and preserves application resources and font scale.
  • Extend Robolectric coverage for appearance translations, formatted background messages, cached language switching, and isolation from the device-language application context.

Validation

  • Local assemblePlainDebug passed.
  • testPlainDebugUnitTest --tests 'yuku.alkitab.base.widget.ConfigurationWrapperLocalizedContextTest' passed: 5 tests, 0 failures, 0 errors.
  • git diff --check passed.
  • No device UI verification performed.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

📱 Preview builds

Signed release builds of 7ea2c55 — version 5.0.0-dev.151 (24006750) — from this run.

Flavor Application ID APK
Alkitab yuku.alkitab Download (7.6 MB)
Quick Bible yuku.alkitab.kjv Download (7.5 MB)
Sabda Alkitab org.sabda.alkitab Download (7.6 MB)

Or open https://58495d40-alkitab-pr.yukuku.workers.dev on an Android device.

These share their application IDs and signature with the Play Store builds, so installing one replaces the corresponding installed app (data is kept).

This comment tracks the latest build for this PR; earlier builds keep their own URLs.

@yukuku
yukuku merged commit ec51501 into develop Oct 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant