Repository navigation
Fix app-language handling in appearance and download messages - #311
Merged
Merged
Conversation
📱 Preview buildsSigned release builds of
Or open https://58495d40-alkitab-pr.yukuku.workers.dev on an Android device. These share their application IDs and signature with the Play Store builds, so installing one replaces the corresponding installed app (data is kept). This comment tracks the latest build for this PR; earlier builds keep their own URLs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation
With Indonesian selected in the app and English on the device, the appearance panel showed “Download more fonts…” and “Color theme” in English. The font option now follows the app language, and the color theme label has the Indonesian translation “Tema warna”.
The same language-context issue is fixed in Bible download failure dialogs and completion toasts, version-list update messages, and the download service's temporary-file rename error.
Technical details
stringResourceand pass the localized label into the font option builder.Localizedhelper, which refreshes its cached resources when the preferred locale changes.ConfigurationWrapper.localizedContextso string lookup copies the configuration and preserves application resources and font scale.Validation
assemblePlainDebugpassed.testPlainDebugUnitTest --tests 'yuku.alkitab.base.widget.ConfigurationWrapperLocalizedContextTest'passed: 5 tests, 0 failures, 0 errors.git diff --checkpassed.