Optional static vs dynamic splat region separation for deformation mode speedup #14
Open
Cedric-Perauer wants to merge 16 commits intoyunjinli:mainfrom
Open
Optional static vs dynamic splat region separation for deformation mode speedup #14Cedric-Perauer wants to merge 16 commits intoyunjinli:mainfrom
Cedric-Perauer wants to merge 16 commits intoyunjinli:mainfrom
Conversation
…should be improved to use absolute values
Added sections for optional static splat masking speedup on Macbook Pro M5 and iPhone 17 Air.
Removed completed TODO items and added a placeholder for other improvements.
Encourage contributions and issue reporting in README.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
a python script that samples timesteps, computes the splat translation over time and stores the movement for each splat in a
mask.binfile (see Issue #13)More Details
mask staticmode which masks static splats from the deformation network, leading to over 5 times faster inference speedVisualisations
Scenes with Speedup
Works very well for scenes with multi-view static camera capture
Macbook M5 Pro : ~15 -> ~100 FPS
fabien_masking.mp4
iPhone 17 Air : ~3 -> ~15 FPS
sear_phone_mask.mov
Macbook M5 Pro : ~20 -> ~35 FPS
basin_masking.mov
Example scene with no achievable speedup
Here we show the split-cookie scene which experiences heavy camera movement as it is not a static multi-view recording, in this case no static splat masking can be done without loosing significant quality in the 4D rendering. Therefore choosing the ideal setting in masking mode converges to the full unmasked rendering for these types of scenes, we therefore recommend keeping it off in that case (which is the default setting).
Further improvements could consider decoupling the camera and scene movement to adjust for this.
cookie_masking_failure.mov